Upgraded app to Ember v3.20 #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlee2
force-pushed
the
upgrade-app-to-3.20
branch
from
717ab81 to
d0e19a5
Compare
ijlee2
commented
Aug 1, 2020
config/targets.js
Outdated
|
|
||
| module.exports = { | ||
| browsers | ||
| browsers: [ |
Member
Author
There was a problem hiding this comment.
At work, I found that allowing last 1 versions can lead to unexpected build errors. I set these targets based on:
For this app, I think it's okay to drop support for IE 11.
Member
There was a problem hiding this comment.
I would recommend not moving away from the default Ember blueprints on these targets.
Member
Author
There was a problem hiding this comment.
Ah, ok. I'll revert them.
Edit: I removed the commit that changed the browser targets.
ijlee2
commented
Aug 1, 2020
| 'Firefox >= 77', | ||
| 'Safari >= 13' | ||
| ], | ||
| node: 'current' |
Member
Author
There was a problem hiding this comment.
RobbieTheWagner
requested changes
Aug 3, 2020
Member
RobbieTheWagner
left a comment
RobbieTheWagner
left a comment
There was a problem hiding this comment.
Just one thing about targets, but the rest looks good!
config/targets.js
Outdated
|
|
||
| module.exports = { | ||
| browsers | ||
| browsers: [ |
Member
There was a problem hiding this comment.
I would recommend not moving away from the default Ember blueprints on these targets.
ijlee2
force-pushed
the
upgrade-app-to-3.20
branch
from
d0e19a5 to
7e01e07
Compare
ijlee2
force-pushed
the
upgrade-app-to-3.20
branch
from
7e01e07 to
08acdd5
Compare
RobbieTheWagner
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes 2 improvements:
ember-sourcefrom v3.19 to v3.20ember-prismto v0.8 to fix a splattributes bug and show line numbersIn particular, the second item addresses and can close #39. (Many thanks to @rwwagner90 for helping with addressing the splattributes bug and making a new release.)
Screenshots
Local server:
Percy snapshot:
There seems to be a height issue in our app such that Percy doesn't correctly render the snapshot. The issue may also be related to
ember-qunitresizing the window. I don't think we need to worry about the snapshot much at the moment.