Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporaray pin of scipy version #461

Open
AVHopp opened this issue Jan 14, 2025 · 4 comments
Open

Temporaray pin of scipy version #461

AVHopp opened this issue Jan 14, 2025 · 4 comments
Assignees
Labels

Comments

@AVHopp
Copy link
Collaborator

AVHopp commented Jan 14, 2025

This issue serves as a reminder that we currently need to explicitly pin the scipy version to <1.15.

This is necessary as this new version caused several problems in other packages, including Botorch and is currently also being pinned there (see here). We can probably remove the explicit pin on our side again once the next version of Botorch has been released, hence the "on hold" label.

@AVHopp AVHopp added the on hold PR progress is awaiting for something else to continue label Jan 14, 2025
@AVHopp AVHopp self-assigned this Jan 14, 2025
@AVHopp
Copy link
Collaborator Author

AVHopp commented Jan 14, 2025

/remind me to check for a new Botorch version next month.

Copy link

@AVHopp set a reminder for 2/14/2025

@Scienfitz
Copy link
Collaborator

Scienfitz commented Feb 6, 2025

It appears the new botorch version is out, according to the CHANGELOG something was done to fix computational problems with newer scipy versions

There are also other changes relevant to us:

@Scienfitz
Copy link
Collaborator

Scienfitz commented Feb 6, 2025

cant find any issue anymore:

Image
(ignore error state its unrelated to this issue here)
Should we unpin scipy and require botorch>=0.13.0 ?

@Scienfitz Scienfitz removed the on hold PR progress is awaiting for something else to continue label Feb 6, 2025
@Scienfitz Scienfitz self-assigned this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants