Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unit tests self-contained #64

Open
CasperWA opened this issue Aug 30, 2021 · 0 comments
Open

Make unit tests self-contained #64

CasperWA opened this issue Aug 30, 2021 · 0 comments
Assignees
Labels
dic2owl Issue or PR related specifically to the dic2owl Python package discussion This issue is a discussion

Comments

@CasperWA
Copy link
Contributor

Since the dic2owl tool downloads various dictionaries it needs for the ontology generation the testing is not self-contained.

To avoid relying on external online resources for testing, either the needed files should be added to the tests/dic2owl/static folder and provided when Python tries to download the various files - or the COMCIFS/cif_core repository should be added as a submodule, since this is where the files are from.

For the latter solution we would potentially always be testing against the latest files (as long as the submodule is updated). Furthermore, the files would not become an actual part of the repository as long as the submodule is not initiated, which it would only need to be for testing purposes.

@CasperWA CasperWA added discussion This issue is a discussion dic2owl Issue or PR related specifically to the dic2owl Python package labels Aug 30, 2021
@CasperWA CasperWA self-assigned this Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dic2owl Issue or PR related specifically to the dic2owl Python package discussion This issue is a discussion
Projects
None yet
Development

No branches or pull requests

1 participant