Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Use named pipes on Windows #2435

Open
1 task done
rvolosatovs opened this issue Jan 6, 2023 · 0 comments
Open
1 task done

[Feature]: Use named pipes on Windows #2435

rvolosatovs opened this issue Jan 6, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers triage Issues that need to be triaged.

Comments

@rvolosatovs
Copy link
Member

rvolosatovs commented Jan 6, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Description

Currently Windows implementation behaves differently from Unix in that it passes Files directly to exec-wasmtime, unlike Unix platforms, where sockets (and file descriptors) are used for that.
This has already been discussed and agreed upon in initial Windows support PR. See this comment and discussion below: #1890 (review)

Acceptance Criteria

No response

Suggestions for a technical implementation

Suggestion from @haraldh in #1890 (comment) was to use https://docs.rs/uds_windows/1.0.2/uds_windows/struct.UnixStream.html#method.pair

But this might restrict us to newer versions of windows, which implement unix sockets.
rust-lang/rust#56533

@rvolosatovs rvolosatovs added enhancement New feature or request triage Issues that need to be triaged. labels Jan 6, 2023
@dpal dpal added this to Enarx Board Jan 12, 2023
@dpal dpal added the good first issue Good for newcomers label Jan 16, 2023
@dpal dpal moved this from New to Backlog in Enarx Board Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers triage Issues that need to be triaged.
Projects
Status: Backlog
Development

No branches or pull requests

2 participants