request crash on certain URLs

[kangzhang]

Hey there, we are running into a crash on httpx and wondering if we could get some help.

It seems rfc3986 is confused by certain URLs. To reproduce the bug:

from httpx import Client
Client().get("https://reason.com/search/?f[author][]=nick-gillespie&q=*&s=-pubdate")

It would throw a ResolutionError error about the URL.

Looking into the code, I'm wondering if we should patch this line and also set query to None: https://github.com/encode/httpx/blob/master/httpx/_models.py#L572

base_uri = self._uri_reference.copy_with(fragment=None, query=None)

The raw exception message:

  File "httpx/_client.py", line 1776, in head
    return await self.request(
  File "httpx/_client.py", line 1481, in request
    response = await self.send(
  File "httpx/_client.py", line 1568, in send
    response = await self._send_handling_auth(
  File "httpx/_client.py", line 1604, in _send_handling_auth
    response = await self._send_handling_redirects(
  File "httpx/_client.py", line 1658, in _send_handling_redirects
    raise exc
  File "httpx/_client.py", line 1647, in _send_handling_redirects
    request = self._build_redirect_request(request, response)
  File "httpx/_client.py", line 456, in _build_redirect_request
    url = self._redirect_url(request, response)
  File "httpx/_client.py", line 508, in _redirect_url
    url = request.url.join(url)
  File "httpx/_models.py", line 573, in join
    return URL(relative_url._uri_reference.resolve_with(base_uri).unsplit())
  File "rfc3986/_mixin.py", line 266, in resolve_with
    raise exc.ResolutionError(base_uri)

Thank you!

[tomchristie]

Thanks! I've escalated this to #1833

[tomchristie]

Your suggestion here looks good to me. (I think).
Would accept any pull requests tweaking that behaviour.

[kangzhang]

Sounds great! I will send a PR.