AUR packages

[p0358]

Just wanted to say I made Arch Linux AUR packages for this thing:

• rpc-bridge
• rpc-bridge-bin
• rpc-bridge-git

They all install to /opt/rpc-bridge, which I think is quite convenient to type e.g. for Steam's /opt/rpc-bridge/bridge.sh %command%

[enderice2]

Thank you! I've been looking how to do this for a while!

[p0358]

You're welcome. If you have an account on AUR and want to be added as co-maintainer at some point too, just let me know.

The only thing we could potentially improve at some point is to let rpc-bridge package use a source code tarball instead of git clone, currently it's impossible since the Makefile for building assumes git is available to query commit and branch (would need to figure out how to get currently built ${pkgver}-${pkgrel} in their place, there's a high change they might simply be passed down as env vars).

[enderice2]

I just created a new account and I will try to learn how to use aur after holidays.

Regarding the issue you mentioned, git command is used only for GIT_COMMIT and GIT_BRANCH env.

https://github.com/EnderIce2/rpc-bridge/blob/d7202716a31a97b51fd6359886778858022d123c/src/Makefile#L4-L9

This is used in logs to know the version of the exe. There might be a workaround for this.

[p0358]

It's baked into the CLI and GUI after the version string. I'm thinking you could use git rev-parse --is-inside-work-tree in the Makefile to check if it's in a git tree and ommit the defs if not. Then in source code don't append it if they're empty with some macro. And this way we'd only have the -git package mention the commit SHA, otherwise just a version would be assumed to be built from the proper tag (technically you then probably should apply a similar change to your binary builds for consistency...).

I guess we could also try passing down the version from AUR into VER_VERSION_STR, but not sure if it's worth the effort (plus it could mismatch with VER_VERSION without further parsing...).

In the Makefile I think you could do something like this (untested) (or maybe something with += to avoid repeating -std=c17):

GIT_IS_INSIDE_WORK_TREE = $(shell git rev-parse --is-inside-work-tree 2>/dev/null || echo false)

ifeq ($(GIT_IS_INSIDE_WORK_TREE),true)
    CFLAGS = -std=c17 -DGIT_COMMIT='"$(GIT_COMMIT)"' -DGIT_BRANCH='"$(GIT_BRANCH)"'
    GIT_COMMIT = $(shell git rev-parse --short HEAD 2>/dev/null)
    GIT_BRANCH = $(shell git rev-parse --abbrev-ref HEAD 2>/dev/null)
else
    CFLAGS = -std=c17
endif

and then some #ifdef in C side of things.

Also added you as co-maintainer to all 3.