Could not resolve engine version for Edition(Some(NaN) warnings

[xvcgreg]

What issue are you facing?

When I switch from default cloud context to local one I get spammed with projectmanager warnings:

(see log section - it's too long to paste here)

Expected behaviour

No unnecessary warnings

Logs

new 17.txt

Enso Version

2023.5.23 nightly

Browser or standalone distribution

Standalone distribution (local project)

Browser Version or standalone distribution

standalone

Operating System

Windows

Operating System Version

Win11pro 22H2 22621.1555

Hardware you are using

12th Gen Intel(R) Core(TM) i9-12900HK / RTX3060 Laptop / Nvidia Drivers 531.68

[JaroslavTulach]

I see:

[org.enso.projectmanager.service.ProjectService] Could not resolve engine version for 
Edition(Some(NaN),None,Map(),Map()).
Falling back to Edition(Some(2023.2.1-nightly.2023.5.23),None,Map(),Map())

not sure what it is caused by, but certainly we can report the error just once.

[xvcgreg]

It might be connected to the fact that all of my projects except today's one was created with an older version or have the version erased from the YAML file?

[hubertp]

This has nothing to do with switching to local context (I saw that message just by randomly using IDE):

[debug] [org.enso.projectmanager.requesthandler.ProjectListHandler] started (org.enso.projectmanager.requesthandler.ProjectListHandler@5437483a)
[warn] [org.enso.projectmanager.service.ProjectService] Could not resolve engine version for Edition(Some(NaN),None,Map(),Map()). Falling back to Edition(Some(0.0.0-dev),None,Map(),Map())
[debug] [org.enso.projectmanager.requesthandler.ProjectListHandler] stopped

[hubertp]

or have the version erased from the YAML file?

@xvcgreg yes, although the Some(NaN) is wrong and misleading.

[hubertp]

Reduced to a simple test-case (now fails):

    "correctly de-serialize missing edition" in {
      val config =
        """name: FooBar
          |edition:
          |""".stripMargin
      val parsed = Config.fromYaml(config).get

      parsed.edition.get.parent shouldBe None
    }

[enso-bot]

Hubert Plociniczak reports a new STANDUP for the provided date (2023-05-26):

Progress: Investigated the problem with reported invalid engine version. The confusing error is when engine value is null (i.e. missing). Apparently circe allows to deserialize null as Int (or Float) and gives it a NaN value, rather than returning a failure. The situation was hard to debug because we have many fallbacks for engine version parsing. Will fix it properly the next day. Also addressing PR review on #6849 and reviewing various reported bugs in LS. It should be finished by 2023-05-29.

Next Day: Next day I will be working on the #6806 task. Provide a fix for the issues.

[hubertp]

#6086 fixed the warning so that it now properly complains about a missing edition (and defaults to some hardcoded version). No warning like the above in the logs.

[enso-bot]

Hubert Plociniczak reports a new STANDUP for yesterday (2023-05-29):

Progress: Addressed PR review. Trying to reproduce errors I once encountered after the GraalVM upgrade. Created #6880 with a proposition for a potential fix. Investigated numerous calls to gu but so far all seems legit, even if unnecessary. Trying to reproduce #6774 but looks like I'm missing the steps to reproduce. Investigating #6874 to find the regression. It should be finished by 2023-05-29.

Next Day: Next day I will be working on the #6806 task. Reviewing tickets