Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mix found things #331

Closed
17 tasks
mixmix opened this issue May 7, 2024 · 2 comments
Closed
17 tasks

Mix found things #331

mixmix opened this issue May 7, 2024 · 2 comments
Assignees
@mixmix
Labels
anchor Issue lists to encapsulate a concept needs-resolution i dont want to see this issue open for much longer

Comments

@mixmix
Copy link
Contributor

mixmix commented May 7, 2024

ExtrinsicBaseClass

  • constructor typescript doesn't appear to be catching the lack of substrate/ signer being passed in
  • get calling things JSON when they are jsObjects

Entropy

  • can't currently import (without dist/ jank)
  • descriptions needed for methods/ getters

EntropyAccount (interface)

  • more detail
  • muddle of sting | Signer inputs
  • make it clear what's optionsal when (it's almost like the SDK has multiple modes... that could be split out to add more clarity and help TS do it's job better)

EntropyOpts

  • make endpoint non-optional?
  • polkadot takes endpoint: string | [string], should we too?

Misc.

  • clarify account on entropy + the key scheme and how they are used

  • dev.deploy

    • GIVE ME THE HASH (even if it's already deployed)
    • confusing name. Just call it "deploy"

  • charlie magic

    • document it's a "free" account / delete it

Tests

  • fetching things then not testing the results

dev/README.md

  • versions note update
@mixmix mixmix self-assigned this May 7, 2024
@frankiebee frankiebee added anchor Issue lists to encapsulate a concept needs-resolution i dont want to see this issue open for much longer labels Jul 24, 2024
@frankiebee
Copy link
Contributor

@mixmix lets progress this

@mixmix
Copy link
Contributor Author

mixmix commented Jan 13, 2025 •
edited
Loading

TODO:

  • pull out individual issues
  • close this by end of week

@mixmix mixmix closed this as completed Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mixmix mixmix

Labels
anchor Issue lists to encapsulate a concept needs-resolution i dont want to see this issue open for much longer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mixmix @frankiebee