Updates for CGGMP'24 #170

fjarri · 2024-12-17T23:45:59Z

Fixes #157
Fixes #43
Fixes #91

Updated paper references in PAPER.md, removed obsolete items.
Updated to the new range definition (±2^l now means [-2^(l-1)+1, 2^(l-1)] instead of the previous [-2^l, 2^l]). This caused a bit of a chain reaction:
- SecretSigned::assert_exponent_range() logic changed.
- SecretSigned::random_in_exp_range*() logic changed, and also exp was changed to exponent to match the assertion name.
- PublicSigned::from_xof_reader_bounded() changed its behavior to produce the number according to the new range definition, and was renamed to from_xof_reader_in_range().
- PublicSigned::in_range_bits() changed its behavior according to the new range definition, and was renamed to is_in_exponent_range().
- Wherever scalars are passed to proofs and Ciphertext constructor they are passed as SecretSigned, to comply with the range requirements in the proofs.
- conversions::secret_unsigned_from_scalar() removed.
- Added SecretSigned::new_modulo() constructor to make a signed number in range [-N/2, N/2] from an Uint in range [0, N).
- Removed Ciphertext::new() and decrypt() (which took unsigned plaintexts), renamed new_signed() and decrypt_signed() to new() and decrypt().
- Ciphertext::new_with_randomizer() was renamed to new_with_randomizer_unsigned(), since it's now a special one, only used in P_mul. Renamed new_with_randomizer_signed() to new_with_randomizer(), and new_public_with_randomizer_signed() to new_public_with_randomizer().
Following that, wherever in the paper e <-- ±q is used, we are sampling the challenge as a Scalar using the new Scalar::from_xof_reader() method (and using that in П^sch as well).
Updated paper references and notation in aff-g proof.
Updated paper references in prm proof, and started using BitVec for its commitment.
Updated dec proof (there were significant changes). Temporarily, it is located in dec_new.rs, will be moved to dec.rs when Presigning is updated.
Added elog proof.
Added enc-elg proof.
Added aff-g* proof.
Updated paper references and notation in fac proof, and implemented necessary changes to the algorithm (some variables are calculated differently, and the challenge is now a signed Uint and not a Scalar)
Updated paper references and notation in mod proof, and enforced invertibility conditions that were added in '24
Updated paper references and notation sch proof
Removed enc, log*, mul, mul* proofs - they are not used anymore.
Encapsulated the invertibility check in an IsInvertible trait, documenting the choice between GCD and invert()
Updated KeyInit and filled in the code for evidence generation/checking. In particular, fixed Self-contained proof of malicious behavior for Round 3 of KeyGen #103 (by using an echo broadcast in Round 2). Also fixed Should key shares have a non-zero scalar type? #5 - we now check that the shares add up to a non-zero scalar.
Updated KeyRefresh to the new version and filled in the code for evidence generation/checking.
Updated Presigning/Signing to the new version
Updated AuxGen to the new version
Renamed ProductionParameters to ProductionParameters112 (since they correspond to 112 bits of security)

Unsolved problems:

Triggering aff-g* checks - see Find a way to test aff-g* proof failures in the error rounds of Presigning #188
128-bit scheme parameters - see Add scheme parameters corresponding to 128 bits of security #189

codecov · 2024-12-19T02:50:15Z

Codecov Report

Attention: Patch coverage is 96.90768% with 139 lines in your changes missing coverage. Please review.

Project coverage is 95.39%. Comparing base (a3bbfc6) to head (c9ea427).

Files with missing lines	Patch %	Lines
synedrion/src/www02/key_resharing.rs	30.55%	25 Missing ⚠️
synedrion/src/cggmp21/entities.rs	80.00%	17 Missing ⚠️
synedrion/src/cggmp21/key_refresh.rs	98.49%	9 Missing ⚠️
synedrion/src/tools/protocol_shortcuts.rs	89.02%	9 Missing ⚠️
synedrion/src/cggmp21/interactive_signing_tests.rs	98.76%	8 Missing ⚠️
synedrion/src/cggmp21/sigma/aff_g_star.rs	96.51%	7 Missing ⚠️
synedrion/src/paillier/encryption.rs	92.78%	7 Missing ⚠️
synedrion/src/tools/protocol_shortcuts_dev.rs	95.59%	7 Missing ⚠️
synedrion/src/cggmp21/aux_gen.rs	98.43%	6 Missing ⚠️
synedrion/src/cggmp21/key_init.rs	97.51%	6 Missing ⚠️
... and 12 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
+ Coverage   92.46%   95.39%   +2.93%     
==========================================
  Files          35       38       +3     
  Lines        7030    10170    +3140     
==========================================
+ Hits         6500     9702    +3202     
+ Misses        530      468      -62

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dvdplm

I have looked at Key_init and Key_refresh tests only.

As mentioned I think it's very cool to see the fault injection machinery come together, it's going to be a major help. The code is verbose and repetitive at times, but this is a complex protocol and its tests are always going to reflect that complexity.
Having the right testing tools is about finding that delicate balance between readability&maintainability and expressiveness. I'm sure we'll fiddle with this plenty mroe in the future but this strikes me as much better than we had before.

synedrion/src/cggmp21/key_init_tests.rs

synedrion/src/cggmp21/key_refresh_tests.rs

synedrion/src/tools/protocol_shortcuts_dev.rs

synedrion/src/cggmp21/key_init_tests.rs

synedrion/src/tools/protocol_shortcuts_dev.rs

dvdplm

Reviewed aux_gen.rs and entities.rs (I'm half-way through interactive_signing.rs but pheew, that one is intense...)

synedrion/src/cggmp21/sigma/mod_.rs

synedrion/src/cggmp21/aux_gen.rs

synedrion/src/cggmp21/entities.rs

dvdplm

Reviewed tools/

synedrion/src/tools/secret.rs

synedrion/src/tools/protocol_shortcuts.rs

synedrion/src/tools/bitvec.rs

dvdplm

Reviewing this update with any actual accuracy sort of boils down to auditing large parts CGGMP which is not something I can actually do. That said I have done my best to check that the overall structure looks sane and I have done a few deep-dives comparing the code with the paper(s).
I think it's ready to be merged, or rather: reviwing it further adds little value. FWIW I am delighted to see the much expanded test suite.

synedrion/src/tools/protocol_shortcuts.rs

synedrion/src/paillier/rsa.rs

synedrion/src/paillier/encryption.rs

dvdplm · 2025-02-10T08:03:45Z

synedrion/src/cggmp21/params.rs

+
+    /// Returns ``true`` if the parameters satisfy a set of inequalities
+    /// required for them to be used for the CGGMP scheme.
+    fn are_self_consistent() -> bool {


I think is_ is more correct, as in "is this (one) set of params self-consistent"? Alternatively just drop the verb and call it self_consistent() -> bool.

synedrion/src/cggmp21/key_refresh.rs

To replace the old dec when we are converting Presigning

fjarri self-assigned this Dec 17, 2024

fjarri force-pushed the new-cggmp branch from b9ed866 to 68a123a Compare December 19, 2024 02:47

fjarri force-pushed the new-cggmp branch 10 times, most recently from 12afc7a to e0565ce Compare December 25, 2024 21:04

fjarri force-pushed the new-cggmp branch 2 times, most recently from cdb7c84 to 0ca10d8 Compare December 31, 2024 22:56

fjarri mentioned this pull request Dec 31, 2024

API adjustments for CGGMP'24 entropyxyz/manul#79

Merged

fjarri force-pushed the new-cggmp branch 2 times, most recently from 0fc38fb to 235afa0 Compare January 3, 2025 22:51

fjarri mentioned this pull request Jan 4, 2025

Protocol writing shortcuts entropyxyz/manul#81

Open

fjarri force-pushed the new-cggmp branch 9 times, most recently from 3efcfd4 to 0f86f18 Compare January 10, 2025 02:47

dvdplm reviewed Jan 10, 2025

View reviewed changes

fjarri commented Jan 10, 2025

View reviewed changes

synedrion/src/tools/protocol_shortcuts_dev.rs Outdated Show resolved Hide resolved

dvdplm reviewed Feb 5, 2025

View reviewed changes

dvdplm reviewed Feb 6, 2025

View reviewed changes

dvdplm approved these changes Feb 10, 2025

View reviewed changes

fjarri added 18 commits February 11, 2025 13:46

Change to the new range definition.

877d6ae

Create challenges as Scalars where +-q range is used

4d60cfe

Add some operator impls

d982963

Update production parameters

35be177

Update aff-g

98659da

Update prm, and use BitVec for its challenge

52d7183

Add the new version of dec

b600a80

To replace the old dec when we are converting Presigning

Add elog

7aed510

Add enc-elg

7bc6bfc

Add aff-g*

cbc06b1

Update fac

08643d7

Update mod

7cea58e

Update sch

e52a78b

Use a single method to check for invertibility

558b70f

Move uint_from_xof to uint::traits

02d0504

Update README

ad72fff

Update KeyInit

542d266

Update KeyRefresh

ab700a5

fjarri force-pushed the new-cggmp branch from 9f6f647 to ab50f70 Compare February 11, 2025 22:24

fjarri mentioned this pull request Feb 11, 2025

Find a way to test aff-g* proof failures in the error rounds of Presigning #188

Open

fjarri force-pushed the new-cggmp branch from ab50f70 to f7aabb4 Compare February 11, 2025 22:40

fjarri added 2 commits February 11, 2025 14:50

Update InteractiveSigning

fa645a1

Update AuxGen

c30afc9

fjarri force-pushed the new-cggmp branch from f7aabb4 to c30afc9 Compare February 11, 2025 22:50

Updated the changelog

c9ea427

fjarri merged commit b20121d into entropyxyz:master Feb 11, 2025
11 checks passed

github-actions bot locked and limited conversation to collaborators Feb 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates for CGGMP'24 #170

Updates for CGGMP'24 #170

fjarri commented Dec 17, 2024 •

edited

Loading

codecov bot commented Dec 19, 2024 •

edited

Loading

dvdplm left a comment

dvdplm left a comment

dvdplm left a comment

dvdplm left a comment

dvdplm Feb 10, 2025

Updates for CGGMP'24 #170

Updates for CGGMP'24 #170

Conversation

fjarri commented Dec 17, 2024 • edited Loading

codecov bot commented Dec 19, 2024 • edited Loading

Codecov Report

dvdplm left a comment

Choose a reason for hiding this comment

dvdplm left a comment

Choose a reason for hiding this comment

dvdplm left a comment

Choose a reason for hiding this comment

dvdplm left a comment

Choose a reason for hiding this comment

dvdplm Feb 10, 2025

Choose a reason for hiding this comment

fjarri commented Dec 17, 2024 •

edited

Loading

codecov bot commented Dec 19, 2024 •

edited

Loading