Skip to content

Commit 3fb37a5

Browse files
authored
Set envoy_reloadable_features_http2_use_oghttp2=false by default (#42319)
Risk Level: Testing: Yes Docs Changes: No Release Notes: Changes the default value of envoy.reloadable_features.http2_use_oghttp2 to false. This changes the codec used for HTTP/2 requests and responses. Once issue 40070 is resolved this will be re-enabled in a future version. Platform Specific Features: xRef: #40070 --------- Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
1 parent 314d263 commit 3fb37a5

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

source/common/runtime/runtime_features.cc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ RUNTIME_GUARD(envoy_reloadable_features_http1_balsa_delay_reset);
5353
RUNTIME_GUARD(envoy_reloadable_features_http1_balsa_disallow_lone_cr_in_chunk_extension);
5454
RUNTIME_GUARD(envoy_reloadable_features_http2_discard_host_header);
5555
RUNTIME_GUARD(envoy_reloadable_features_http2_propagate_reset_events);
56-
RUNTIME_GUARD(envoy_reloadable_features_http2_use_oghttp2);
5756
// Delay deprecation and decommission until UHV is enabled.
5857
RUNTIME_GUARD(envoy_reloadable_features_http_reject_path_with_fragment);
5958
RUNTIME_GUARD(envoy_reloadable_features_mobile_use_network_observer_registry);
@@ -198,6 +197,9 @@ FALSE_RUNTIME_GUARD(envoy_reloadable_features_fixed_heap_use_allocated);
198197
// TODO(yavlasov): Enabling by default will be hugely disruptive to existing traffic.
199198
// Replace with a config option (default off) post CVE release.
200199
FALSE_RUNTIME_GUARD(envoy_reloadable_features_reject_early_connect_data);
200+
// Flip back to true once performance aligns with nghttp2 and
201+
// https://github.com/envoyproxy/envoy/issues/40070 is resolved.
202+
FALSE_RUNTIME_GUARD(envoy_reloadable_features_http2_use_oghttp2);
201203

202204
// Block of non-boolean flags. Use of int flags is deprecated. Do not add more.
203205
ABSL_FLAG(uint64_t, re2_max_program_size_error_level, 100, ""); // NOLINT

0 commit comments

Comments
 (0)