Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oghttp2 doesn't handle classic connect requests #21386

Closed
alyssawilk opened this issue May 19, 2022 · 6 comments
Closed

oghttp2 doesn't handle classic connect requests #21386

alyssawilk opened this issue May 19, 2022 · 6 comments
Assignees
@diannahu @birenroy
Labels
enhancement Feature requests. Not bugs or questions.

Comments

@alyssawilk
Copy link
Contributor

alyssawilk commented May 19, 2022 •
edited
Loading

:method CONNECT
:authority host:80

appears to bounce

Semi-blocking #20378
@alyssawilk alyssawilk added the enhancement Feature requests. Not bugs or questions. label May 19, 2022
@alyssawilk
Copy link
Contributor Author

also if you want a terrible repro patch, you can take https://github.com/envoyproxy/envoy/compare/main...alyssawilk:extended?expand=1 and comment out the force-override to nghttp2

@birenroy
Copy link
Contributor

Okay, support for "classic" CONNECT is in upstream QUICHE now:
google/quiche@4e85f2a

@alyssawilk
Copy link
Contributor Author

still getting "Violation in HTTP messaging rule"
Are you sure this patch addresses the fact that CONNECT requests don't need to have path and scheme?

@alyssawilk
Copy link
Contributor Author

Ah I think I found the issue.
If extended connect is configured aren't we allowed to use either classic or extended connect? I think the code as written only allows extended connect if it's configured.

@birenroy
Copy link
Contributor

Alright, please try the latest commit:
google/quiche@0eae705

@alyssawilk
Copy link
Contributor Author

That did it, thanks! I'll mark this closed as it'll be fixed as of next import :-)

@alyssawilk alyssawilk mentioned this issue May 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diannahu diannahu

@birenroy birenroy

Labels
enhancement Feature requests. Not bugs or questions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update QUICHE from bfd723274 to 0eae705e3 alyssawilk/envoy
3 participants
@diannahu @birenroy @alyssawilk