Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tunneling_config: support dynamic Hostname #21804

Closed
howardjohn opened this issue Jun 21, 2022 · 1 comment
Closed

tunneling_config: support dynamic Hostname #21804

howardjohn opened this issue Jun 21, 2022 · 1 comment
Labels
area/tcp_proxy enhancement Feature requests. Not bugs or questions.

Comments

@howardjohn
Copy link
Contributor

Title: tunneling_config: support dynamic Hostname

Description:
We have a use case to have the tunnel Hostname dynamically configurable. We previously did this in custom headers (which use HeaderValueOption), but thanks to #21440 we can now use the proper :authority header for this. However, hostname is just a string. We would like it to support dynamic values as well, such as %DYNAMIC_METADATA(["tunnel", "address"])%

The alternative -- to create 1000s of different tunnel configs for each address - is not scale-able.

[optional Relevant Links:]

Any extra documentation required to understand the issue.
@howardjohn howardjohn added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Jun 21, 2022
@ggreenway ggreenway added area/tcp_proxy and removed triage Issue requires triage labels Jun 21, 2022
@kyessenov
Copy link
Contributor

Duplicate of #19612

@kyessenov kyessenov marked this as a duplicate of #19612 Jun 22, 2022
@howardjohn howardjohn mentioned this issue Jun 22, 2022
Merged
kyessenov pushed a commit that referenced this issue Jul 6, 2022
@jewertow
tcp_proxy: support command operators in tunneling_config.hostname (#2…
764a2e9 
…1067)

Signed-off-by: Jacek Ewertowski jacek.ewertowski1@gmail.com

Commit Message: tcp_proxy: support command operators in tunneling_config.hostname
Additional Description: This change enables dynamically setting tunneling_config.hostname with command operators. 
This pull request is an alternative for auto_sni.
This change allows to configure TCP proxy as follows:
```
tunneling_config:
  hostname: %REQUESTED_SERVER_NAME%:443
```
Risk Level: Low
Testing: added unit tests
Docs Changes: done
Release Notes: done
Platform Specific Features: none
Fixes #19612
Fixes #21804
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/tcp_proxy enhancement Feature requests. Not bugs or questions.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@howardjohn @ggreenway @kyessenov