Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Path cannot be overwritten when using TCP tunneling #24038

Closed
ohadvano opened this issue Nov 17, 2022 · 1 comment · Fixed by #24045
Closed

Path cannot be overwritten when using TCP tunneling #24038

ohadvano opened this issue Nov 17, 2022 · 1 comment · Fixed by #24045
Assignees
@soulxu
Labels
area/tcp_proxy enhancement Feature requests. Not bugs or questions.

Comments

@ohadvano
Copy link
Contributor

Title: Path is hardcoded as "/" and cannot be overwritten when using TCP tunneling

Description: When using HTTP upgrades for TCP tunneling it is sometimes required to select a custom path, for HTTP POST request, for instance. Currently path is hard coded as "/" in the source code. Feature suggested is adding an option to overwrite the path by configuration.

[optional Relevant Links:]
Slack discussion over this topic: https://envoyproxy.slack.com/archives/C78HA81DH/p1666598752138609
@ohadvano ohadvano added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Nov 17, 2022
@soulxu soulxu mentioned this issue Nov 17, 2022
Merged
@soulxu
Copy link
Member

soulxu commented Nov 17, 2022

seems simple to support, submit a pr directly #24045

@zuercher zuercher added area/tcp_proxy and removed triage Issue requires triage labels Nov 17, 2022
lizan pushed a commit that referenced this issue Nov 28, 2022
@soulxu
tcp proxy: enable to specify a path for HTTP tunneling with POST meth…
ea2cdc3 
…od (#24045)

Risk Level: low
Testing: unittest
Docs Changes: API doc
Release Notes: new feature
Fixes #24038

Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soulxu soulxu

Labels
area/tcp_proxy enhancement Feature requests. Not bugs or questions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tcp proxy: enable to specify a path for HTTP tunneling with POST method soulxu/envoy
3 participants
@zuercher @soulxu @ohadvano