-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: making the lua filter a dual filter #38465
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
/wait on ci |
…nd new functionality. Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
I'm seeing TSAN timing out in the middle of running the integration tests (the new integration test covers more combinations so it takes longer). I'm seeing the timeout set to 180 min in
(I ran TSAN locally and it passes, so pretty sure it's just a time-out issue) |
/retest |
1 similar comment
/retest |
… class for upstream filters results in 1216 tests Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
timeout still seems to be 30 min, even though I changed the test's I'm really not sure where that 30 minute value is coming from.. @wbpcode do you have any idea? |
Sorry, I also have no much idea. 😞 An eternal should use 3600s as the timeout. I think @phlax may could helps to this CI timeout problem. |
this is the execution log https://mordenite.cluster.engflow.com/actions/executions/ChCgHfMQ0UNCiqLjEC0JFA-PEgdkZWZhdWx0GiUKIBR15GaFEZlQjH9EFo_3Ehks2raEKWcQQPwE5Z0MFeBPEKgD which suggests that the timeout is set to 4800s - so confused either way - it would be better to avoid setting enormous im wondering if the test can be made quicker - as 30m+ is a long time for a test would increasing core count help at all? |
I believe google-test runs all the test of a single binary serially; so not sure if that would help. That said, if its easy to change, maybe worth a try? |
yeah - given it fails reliably - change in the test rule |
Another option to make the test take less time is to remove http3 testing... not sure if it adds value for lua integration testing. running it locally without http3 takes around 600s which is ~50% percent less than before (1180s) |
…a integration test Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Commit Message:
http: making the lua filter a dual filter
Additional Description: n/a
Risk Level: Low
Testing: Updated integration tests
Docs Changes: n/a
Release Notes: inline
Platform Specific Features: n/a
Part of #10455