ext_proc: refactor the allowed override modes #42404
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
adisuissa
requested review from
mattklein123,
tyxia and
yanavlasov
as code owners
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: ext_proc: refactor the allowed override modes
Additional Description:
Prior to this PR the allowed override modes were kept in a vector of enums, and the comparison had an O(n) time complexity.
This PR introduces a new data-structure that converts each ProcessingMode to a single number, and keeps that in a set. Should reduce both memory consumption and time complexity.
Risk Level: low - internal refactor
Testing: Added unit tests for the data-structure
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A