mobile: Use a Mock DNS resolver in integration tests #42421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change does two things:
1. Creates a new MockDnsResolver that can be used for mobile
integration tests setting the host to a non-local host.
2. Updates ClientIntegrationTest to use the MockDnsResolver for tests
that attempt to connect to a non-existant host.
The MockDnsResolver treats localhost addresses like a standard DNS
resolver would, but for the configured "non-existant" hosts, it returns
an empty DNS record (EAI_NONAME) without attempting to go on the wire to
fetch the host's DNS records. This saves test time and makes for a more
hermetic test.
Signed-off-by: Ali Beyad <abeyad@google.com>
Contributor
Author
|
/assign @phlax |
Contributor
Author
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does two things:
The MockDnsResolver treats localhost addresses like a standard DNS resolver would, but for the configured "non-existant" hosts, it returns an empty DNS record (EAI_NONAME) without attempting to go on the wire to fetch the host's DNS records. This saves test time and makes for a more hermetic test.