From 195211e1df73b946af9adaee1e3e6732d24334dd Mon Sep 17 00:00:00 2001
From: Christoph Reimer <christoph.reimer@eodc.eu>
Date: Thu, 14 Nov 2024 15:50:57 +0100
Subject: [PATCH] add server config as separate file.

---
 jupyter_server_config.json                  |  8 ++++++++
 jupyterlab/eodc-minimal-notebook.dockerfile | 22 ++-------------------
 2 files changed, 10 insertions(+), 20 deletions(-)
 create mode 100644 jupyter_server_config.json

diff --git a/jupyter_server_config.json b/jupyter_server_config.json
new file mode 100644
index 0000000..83ec1ef
--- /dev/null
+++ b/jupyter_server_config.json
@@ -0,0 +1,8 @@
+{
+  "ServerApp": {
+    "contents_manager_class": "jupyterfs.metamanager.MetaManager",
+    "jpserver_extensions": {
+      "jupyterfs.extension": true
+    }
+  },
+}
\ No newline at end of file
diff --git a/jupyterlab/eodc-minimal-notebook.dockerfile b/jupyterlab/eodc-minimal-notebook.dockerfile
index e86cae8..7ffae70 100644
--- a/jupyterlab/eodc-minimal-notebook.dockerfile
+++ b/jupyterlab/eodc-minimal-notebook.dockerfile
@@ -42,25 +42,7 @@ RUN pip install --no-cache-dir --upgrade \
 
 RUN jupyter lab build --minimize=False -y
 
-RUN pip install --no-cache-dir --upgrade jupyter-fs \
-  cat << 'EOF' > /etc/jupyter/jupyter_server_config.json \
-  { \
-    "ServerApp": { \
-      "contents_manager_class": "jupyterfs.metamanager.MetaManager", \
-      "jpserver_extensions": { \
-        "jupyterfs.extension": true \
-      } \
-    }, \
-    "JupyterFs": { \
-      "resources": [ \
-        { \
-          "name": "EODC S3", \
-          "url": "s3:///{{key}}:{{secret}}@{{bucket}}", \
-          "endpoint": "objectstore.eodc.eu:2222" \
-        } \
-      ] \
-    } \
-  } \
-  EOF
+RUN pip install --no-cache-dir --upgrade jupyter-fs
+COPY ./jupyter_server_config.json /etc/jupyter/jupyter_server_config.json
 
 USER ${NB_UID}
\ No newline at end of file