You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
### Workflow instantiation
Makes the creation of `Workflow` objects more flexible by accepting `kwargs` that can be workflow/calculator/plotting parameters e.g.
```
wf = SinglepointWorkflow(atoms, functional='ki', ecutwfc=40.0)
```
whereas previously this would have to be
```
wf = SinglepointWorkflow(atoms, parameters={'functional': 'ki}, master_calc_params={'kcp': {'ecutwfc': 40.0}, 'pw': {'ecutwfc': 40}})
```
Closes#145
### Changes to running subworkflows
This PR also introduces the `@classmethod` `fromparent` to the `Workflow` class and deprecated `Workflow.wf_kwargs` and `Workflow.run_subworkflow()`. Previously to create and run a subworkflow one had to do something like
```
subwf = Workflow(**self.kwargs)
self.run_subworkflow(subwf)
```
but instead now we do
```
subwf = Workflow.fromparent(self)
subwf.run()
```
which is cleaner and more pythonic
### Documentation
Added the docstrings of the `Workflow` class to the docs module using `autodoc` and `numpydoc`. This starts to address (but does not fully resolve) #147
See here for details of the autodoc extension.
Will require us to tidy up the docstrings of these classes
The text was updated successfully, but these errors were encountered: