Skip to content

Commit f33ac48

Browse files
authored
Merge pull request #114 from xmtp-labs/saulmc/add-members
Clean up add member screen
2 parents 84b8e13 + 9c74f98 commit f33ac48

File tree

9 files changed

+144
-111
lines changed

9 files changed

+144
-111
lines changed

ios/EphemeraMobileChat.xcodeproj/project.pbxproj

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -672,11 +672,7 @@
672672
"-DFOLLY_USE_LIBCPP=1",
673673
"-DFOLLY_CFG_NO_COROUTINES=1",
674674
);
675-
OTHER_LDFLAGS = (
676-
"$(inherited)",
677-
"-Wl",
678-
"-ld_classic",
679-
);
675+
OTHER_LDFLAGS = "$(inherited)";
680676
REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
681677
SDKROOT = iphoneos;
682678
SWIFT_VERSION = 5.0;
@@ -745,11 +741,7 @@
745741
"-DFOLLY_USE_LIBCPP=1",
746742
"-DFOLLY_CFG_NO_COROUTINES=1",
747743
);
748-
OTHER_LDFLAGS = (
749-
"$(inherited)",
750-
"-Wl",
751-
"-ld_classic",
752-
);
744+
OTHER_LDFLAGS = "$(inherited)";
753745
REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
754746
SDKROOT = iphoneos;
755747
SWIFT_VERSION = 5.0;

ios/Podfile.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1666,8 +1666,8 @@ SPEC CHECKSUMS:
16661666
web3.swift: 2263d1e12e121b2c42ffb63a5a7beb1acaf33959
16671667
XMTP: 1deb40ac712ba315dcfdecd590a9b924d8c2241a
16681668
XMTPReactNative: ffc7fb00c38f3d3f8af038ae5d1f9712cac0bb5f
1669-
Yoga: 2a16e58450c48e110211dae1159fb114bbcdcfc0
1669+
Yoga: e5b887426cee15d2a326bdd34afc0282fc0486ad
16701670

16711671
PODFILE CHECKSUM: 47641fd2f7a6fc6169785131e7615d136e56edd8
16721672

1673-
COCOAPODS: 1.15.2
1673+
COCOAPODS: 1.14.3

src/components/ConversationListHeader.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export const ConversationListHeader: FC<ConversationListHeaderProps> = () => {
2323
const {avatarUrl} = useContactInfo(address);
2424

2525
const handleNewMessagePress = useCallback(() => {
26-
navigate(ScreenNames.Search);
26+
navigate(ScreenNames.CreateGroup);
2727
}, [navigate]);
2828

2929
const handleAccountPress = useCallback(() => {

src/i18n/locales/en.json

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@
1818
"no": "No",
1919
"yes": "Yes",
2020
"start": "Start",
21-
"recents": "Recents",
21+
22+
"recents": "Recent",
2223
"contacts": "Contacts",
2324
"your_interoperable_web3_inbox": "Your interoperable web3 inbox",
2425
"youre_just_a_few_steps_away_from_secure_wallet_to_wallet_messaging": "You're just a few steps away from secure, wallet-to-wallet messaging",
@@ -43,6 +44,7 @@
4344
"guest_wallet": "Guest Wallet",
4445
"group_changed": "Group Changed",
4546
"add_to_group": "Add",
47+
"add_members_to_group": "Add members",
4648
"group": "Group",
4749
"dev_screen": "Dev Screen",
4850
"client": "Client",
@@ -68,5 +70,8 @@
6870
"reply": "Reply",
6971
"conversation_replying_to": "Replying to %{name}",
7072
"replied_to": "Replied to an earlier message",
71-
"group_chats": "Group Chats"
72-
}
73+
"group_chats": "Group Chats",
74+
75+
"cancel": "Cancel",
76+
"create_group": "Create"
77+
}

src/navigation/AppNavigation.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@ import {Platform} from 'react-native';
55
import {useClientContext} from '../context/ClientContext';
66
import {AccountSettingsScreen} from '../screens/AccountSettingsScreen';
77
import {ConversationListScreen} from '../screens/ConversationListScreen';
8+
import {CreateGroupScreen} from '../screens/CreateGroupScreen';
89
import {DevScreen} from '../screens/DevScreen';
910
import {GroupScreen} from '../screens/GroupScreen';
1011
import {LoadingScreen} from '../screens/LoadingScreen';
1112
import {NewConversationScreen} from '../screens/NewConversationScreen';
1213
import {OnboardingConnectWalletScreen} from '../screens/OnboardingConnectWalletScreen';
1314
import {OnboardingEnableIdentityScreen} from '../screens/OnboardingEnableIdentityScreen';
1415
import {QrCodeScreen} from '../screens/QrCodeScreen';
15-
import {SearchScreen} from '../screens/SearchScreen';
1616
import {UserProfilesScreen} from '../screens/UserProfilesScreen';
1717
import {ScreenNames} from './ScreenNames';
1818
import {
@@ -87,8 +87,8 @@ export const AppNavigation = () => {
8787
component={NewConversationScreen}
8888
/>
8989
<AuthenticatedStack.Screen
90-
name={ScreenNames.Search}
91-
component={SearchScreen}
90+
name={ScreenNames.CreateGroup}
91+
component={CreateGroupScreen}
9292
options={{
9393
presentation: 'modal',
9494
}}

src/navigation/ScreenNames.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export enum ScreenNames {
1010
ConversationList = 'conversation_list',
1111
Group = 'group',
1212
NewConversation = 'new_conversation',
13-
Search = 'search',
13+
CreateGroup = 'create_group',
1414
QRCode = 'qr_code',
1515
UserProfiles = 'user_profiles',
1616
Dev = 'dev',

src/navigation/StackParams.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export type AuthenticatedStackParams = {
1414
[ScreenNames.ConversationList]: undefined;
1515
[ScreenNames.Group]: {topic: string};
1616
[ScreenNames.NewConversation]: {addresses: string[]};
17-
[ScreenNames.Search]: undefined;
17+
[ScreenNames.CreateGroup]: undefined;
1818
[ScreenNames.QRCode]: undefined;
1919
[ScreenNames.UserProfiles]: {address: string};
2020
[ScreenNames.Dev]: undefined;

src/navigation/linkingDefinition.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export const linkingDefinition: LinkingOptions<RootStackParams> = {
2020
addresses: addresses => addresses.split(','),
2121
},
2222
},
23-
[ScreenNames.Search]: 'search',
23+
[ScreenNames.CreateGroup]: 'create_group',
2424
[ScreenNames.QRCode]: 'qr_code',
2525
[ScreenNames.UserProfiles]: 'user_profiles',
2626
},

0 commit comments

Comments
 (0)