Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting meta #303

Open
3 tasks
Tracked by #206
athowes opened this issue Sep 10, 2024 · 0 comments
Open
3 tasks
Tracked by #206

Plotting meta #303

athowes opened this issue Sep 10, 2024 · 0 comments
Labels
medium Nice to have for next release

Comments

@athowes
Copy link
Collaborator

athowes commented Sep 10, 2024

Background

  • In PR Cut plots for now #292 we removed all of the old plotting functionality from this package.
  • I think that this package should have some plotting functionality, but it should be focused on figures that are sufficiently commonly required and with enough "gotchas" that users might find it hard to produce them themselves
  • With this in mind, I think that we likely shouldn't be providing plotting functionality aimed at users running simulation studies like that of https://github.com/parksw3/epidist-paper

Existing plots in vignettes

Other ideas not in vignettes at the moment

  • Posterior plot (point and interval) of the estimated delay parameters to include both brms parameters and natural scale parameters
  • Estimated delay distribution figures to include
    1. Uncertainty
    2. Observed frequencies (i.e. the data)

Synthesis of what I think we should support

  1. Some way to visualise the observed data. Similar to the plot of primary and secondary event times in the vignettes. Maybe this interacts somehow with preprocessing or model classes.
  2. Some way to plot generated discrete and continuous representations of delay distributions, ideally on the same figure. Perhaps we need some structure for how the outputs should look.
  • Perhaps the part about being able to combine discrete and continuous, and various facets or otherwise, might be challenging
  • I think we should be able to include the data in this plot
  • And I think being able to visualise uncertainty here would be good
  1. (Maybe) some kind of helper for plotting posterior distributions of delay parameters (and on the natural scale)

Next steps

  • Get input from others on these ~ two figures being what we should support
  • Draft versions of the two figures
    • Standard documentation, tests, ...
  • Replace existing figures in the vignette with this code
@athowes athowes added the medium Nice to have for next release label Sep 10, 2024
@athowes athowes mentioned this issue Sep 11, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Nice to have for next release
Projects
None yet
Development

No branches or pull requests

1 participant