Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further entrypoints to linelist data class #414

Open
athowes opened this issue Nov 1, 2024 · 2 comments
Open

Further entrypoints to linelist data class #414

athowes opened this issue Nov 1, 2024 · 2 comments
Labels
medium Nice to have for next release

Comments

@athowes
Copy link
Collaborator

athowes commented Nov 1, 2024

In PR #390 we added an initial single entry point to epidist_linelist requiring the following input columns:

as_epidist_linelist <- function(
  data, pdate_lwr = NULL, pdate_upr = NULL, sdate_lwr = NULL, sdate_upr = NULL, obs_date = NULL
) {

There might be other entry points we would want to add. For example, we also needed a temporary entry point for those that already have time data available:

as_epidist_linelist_time <- function(data) {
  class(data) <- c("epidist_linelist", class(data))
  epidist_validate_data(data)
  return(data)
}

As part of this issue I think we should scope out and implement the entry points to data being in the epidist_linelist class.

@athowes
Copy link
Collaborator Author

athowes commented Nov 1, 2024

@seabbs writes that:

My preference would be this is part of the simulation workflow and likely works via adding dates to simulated times but as above I think it needs some thought

Here "simulation workflow" refers to a possible section of the package for working with simulated data.

This supposes that a user would usually/only have time data if it were simulated. It's not clear to me that this is true.

@athowes
Copy link
Collaborator Author

athowes commented Nov 13, 2024

image

@athowes athowes added the medium Nice to have for next release label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Nice to have for next release
Projects
None yet
Development

No branches or pull requests

1 participant