Skip to content

Commit 7b81073

Browse files
committed
Add unit tests for empty job name
1 parent d7f69ea commit 7b81073

File tree

3 files changed

+23
-0
lines changed

3 files changed

+23
-0
lines changed

tests/ert/unit_tests/scheduler/test_lsf_driver.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1167,6 +1167,13 @@ async def test_submit_with_resource_requirement_with_bsub_capture():
11671167
assert "hname" not in Path("captured_bsub_args").read_text(encoding="utf-8")
11681168

11691169

1170+
@pytest.mark.usefixtures("capturing_bsub")
1171+
async def test_empty_job_name():
1172+
driver = LsfDriver()
1173+
await driver.submit(0, "/bin/sleep")
1174+
assert " -J sleep " in Path("captured_bsub_args").read_text(encoding="utf-8")
1175+
1176+
11701177
@pytest.mark.integration_test
11711178
@pytest.mark.usefixtures("use_tmpdir")
11721179
async def test_submit_with_num_cpu(pytestconfig, job_name):

tests/ert/unit_tests/scheduler/test_openpbs_driver.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,13 @@ async def test_job_name():
165165
assert " -Nsleepy " in Path("captured_qsub_args").read_text(encoding="utf-8")
166166

167167

168+
@pytest.mark.usefixtures("capturing_qsub")
169+
async def test_empty_job_name():
170+
driver = OpenPBSDriver()
171+
await driver.submit(0, "/bin/sleep")
172+
assert " -Nsleep " in Path("captured_qsub_args").read_text(encoding="utf-8")
173+
174+
168175
@pytest.mark.usefixtures("capturing_qsub")
169176
async def test_job_name_with_prefix():
170177
driver = OpenPBSDriver(job_prefix="pre_")

tests/ert/unit_tests/scheduler/test_slurm_driver.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,15 @@ async def test_project_code_is_set(project_code):
144144
)
145145

146146

147+
@pytest.mark.usefixtures("capturing_sbatch")
148+
async def test_empty_job_name():
149+
driver = SlurmDriver()
150+
await driver.submit(0, "/bin/sleep")
151+
assert "--job-name=sleep" in Path("captured_sbatch_args").read_text(
152+
encoding="utf-8"
153+
)
154+
155+
147156
@pytest.mark.usefixtures("capturing_sbatch")
148157
@given(max_runtime=st.floats(min_value=1, max_value=999999999))
149158
async def test_max_runtime_is_properly_formatted(max_runtime):

0 commit comments

Comments
 (0)