Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor update workflow signature #9607

Open
oyvindeide opened this issue Dec 20, 2024 · 0 comments
Open

Refactor update workflow signature #9607

oyvindeide opened this issue Dec 20, 2024 · 0 comments

Comments

@oyvindeide
Copy link
Collaborator

Currently the UpdateWorkflow takes in ESSettings in the constructor, but should probably be just the base settings:

ert/src/ert/config/analysis_module.py

Line 19 in 1889e2a

class BaseSettings(BaseModel):
, as no particular algorithm is configured for this. The run models for the other algorithms should require the corresponding configuration that they depend on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
SCOUT
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oyvindeide