Make area required in missionRun/Definition

Author: andchiind

backend/api.test/Database/DatabaseUtilities.cs

@@ -44,7 +44,7 @@ public void Dispose()
         public async Task<MissionRun> NewMissionRun(
             string installationCode,
             Robot robot,
-            Area? area,
+            Area area,
             bool writeToDatabase = true
         )
         {

backend/api/Controllers/MissionSchedulingController.cs

@@ -171,6 +171,11 @@ [FromBody] ScheduledMissionQuery scheduledMissionQuery
             Area? area = null;
             area = missionAreas.GroupBy(i => i).OrderByDescending(grp => grp.Count()).Select(grp => grp.Key).First();
 
+            if (area == null)
+            {
+                return NotFound($"No area with name {scheduledMissionQuery.AreaName} in installation {scheduledMissionQuery.InstallationCode} was found");
+            }
+
             var source = await sourceService.CheckForExistingEchoSource(scheduledMissionQuery.EchoMissionId);
             MissionDefinition? existingMissionDefinition = null;
             if (source == null)
@@ -264,6 +269,7 @@ [FromBody] CustomMissionQuery customMissionQuery
             MissionDefinition? customMissionDefinition;
             try { customMissionDefinition = await customMissionSchedulingService.FindExistingOrCreateCustomMissionDefinition(customMissionQuery, missionTasks); }
             catch (SourceException e) { return StatusCode(StatusCodes.Status502BadGateway, e.Message); }
+            catch (AreaNotFoundException) { return NotFound($"No area with name {customMissionQuery.AreaName} in installation {customMissionQuery.InstallationCode} was found"); }
 
             try { await localizationService.EnsureRobotIsOnSameInstallationAsMission(robot, customMissionDefinition); }
             catch (InstallationNotFoundException e) { return NotFound(e.Message); }

backend/api/Database/Models/MissionDefinition.cs

@@ -28,7 +28,8 @@ public class MissionDefinition : SortableRecord
 
         public virtual MissionRun? LastSuccessfulRun { get; set; }
 
-        public Area? Area { get; set; }
+        [Required]
+        public Area Area { get; set; }
 
         public bool IsDeprecated { get; set; }
     }

backend/api/Database/Models/MissionRun.cs

@@ -69,7 +69,8 @@ public IList<MissionTask> Tasks
         [MaxLength(1000)]
         public string? Comment { get; set; }
 
-        public Area? Area { get; set; }
+        [Required]
+        public Area Area { get; set; }
 
         public bool IsCompleted =>
             _status