Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend and backend uses different inspectiontargets #1353

Closed
Eddasol opened this issue Jan 24, 2024 · 0 comments · Fixed by #1362
Closed

Frontend and backend uses different inspectiontargets #1353

Eddasol opened this issue Jan 24, 2024 · 0 comments · Fixed by #1362
Assignees
@Eddasol
Labels
bug Something isn't working

Comments

@Eddasol
Copy link
Contributor

Eddasol commented Jan 24, 2024 •
edited
Loading

Describe the bug
Frontend uses task.inspectiontarget, backend/isar uses task.inspections[x].inspectiontarget

Suggested solution:

  • Rewrite all use of task.inspectionTarget to use task.inspections[x].inspectiontarget instead (possibly also make task.inspectionTarget optional to avoid bugs during the removal)
    • Frontend use of task.inspectionTarget
    • Mission tasks stored in blobstore having task.inspectionTarget
  • Remove inspectiontarget from task

To Reproduce

Expected behavior

Screenshots
@Eddasol Eddasol added the bug Something isn't working label Jan 24, 2024
@Eddasol Eddasol self-assigned this Jan 26, 2024
@Eddasol Eddasol linked a pull request Jan 26, 2024 that will close this issue
Remove use of Task.InspectionTarget #1362
Merged
@Eddasol Eddasol reopened this Jan 30, 2024
@Eddasol Eddasol closed this as completed Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eddasol Eddasol

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove use of Task.InspectionTarget Eddasol/flotilla
1 participant
@Eddasol