Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing media-stream silently #1952

Open
tsundvoll opened this issue Jan 15, 2025 · 0 comments · May be fixed by #1967
Open

Handle missing media-stream silently #1952

tsundvoll opened this issue Jan 15, 2025 · 0 comments · May be fixed by #1967
Assignees
Labels
bug Something isn't working

Comments

@tsundvoll
Copy link
Contributor

Describe the bug
For the Placebots we don't have a media-stream available. Currently that leads to a error in the logs, but I think it should not be an error.

To Reproduce
Steps to reproduce the behavior:

  1. Open Flotilla in dev or staging for Huldra
  2. Open a previous mission for Placebot huldra
  3. See in the console (F12) two error messages is logged:
Failed to GET /media-stream/3211b670-2723-434b-948e-c27e440544a4: 404 -
Error: No media config retrieved for robot with ID 3211b670-2723-434b-948e-c27e440544a4

Expected behavior
The error messages are not useful -> We don't expect any video streams for the Placebots.

Instead of returning 404 Not found; the backend can return 200 Success with [] empty payload; indicating that no media stream / config is available for this robot.

Screenshots

Image

@tsundvoll tsundvoll added the bug Something isn't working label Jan 15, 2025
@Eddasol Eddasol self-assigned this Jan 17, 2025
@Eddasol Eddasol linked a pull request Jan 17, 2025 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants