Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-adaptive localisation fails when using FIELD in ERT config and there are no specified keyword for field_scale for the same correlation group #488

Open
oddvarlia opened this issue Dec 22, 2022 · 1 comment
Labels
christmas-review Issues and PRs for Christmas review

Comments

@oddvarlia
Copy link
Contributor

Describe the bug
The non-adaptive localisation implemented in the job LOCALISATION_JOB in semeio fails if the ERT model contains fields and localisation config specify correlation group containing the field parameter but without specifying field_scale keyword in the localisation config. What happens now is that missing specification of row_scaling input for this case makes localisation fail.

To Reproduce
Run the localisation job using a correlation group which uses a field parameter in the parameter group and where no specification of scaling was specified (e.g. missing the keyword field_scale in the localisation config file for that correlation group.

Expected behavior
The localisation should work also in this case, but with scaling factor equal to 1 for the fields in the correlation group. This means that original estimated correlations between the field parameter values and the observations in the correlation group should be kept unmodified. What A clear and concise description of what you expected to happen.

@oddvarlia oddvarlia changed the title Non-adaptive localisation fails when using FIELD in ERT config and not keyword for field_scale is used in localisation config Non-adaptive localisation fails when using FIELD in ERT config and there are no specified keyword for field_scale for the same correlation group Dec 22, 2022
@oddvarlia
Copy link
Contributor Author

The purpose was to run with field without having to use any method to modify the correlation by distance or region. By introducing a method constant we can achieve this with default scaling = 1.

@eivindjahren eivindjahren added the christmas-review Issues and PRs for Christmas review label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
christmas-review Issues and PRs for Christmas review
Projects
None yet
Development

No branches or pull requests

2 participants