Skip to content

Commit e738066

Browse files
committed
Debugging radix state response
1 parent c9492d5 commit e738066

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

backend/src/backend/primary/routers/dev/dev_radix_helpers.py

+8-6
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@ async def create_new_radix_job(job_component_name: str, job_scheduler_port: int)
7171
LOGGER.error(f"Request returned HTTP error {exc.response.status_code} for POST to {exc.request.url!r}")
7272
return None
7373

74-
# According to doc it seems we should be getting a json back that contains a status field,
75-
# which should be "Running" if the job was started successfully.
74+
# According to the docs it seems we should be getting a json back that contains a
75+
# status field, which should be "Running" if the job was started successfully.
7676
# Apparently this is not the case, as of Feb 2024, the only useful piece of information we're getting
7777
# back from this call is the name of the newly created job.
7878
response_dict = response.json()
@@ -93,11 +93,13 @@ async def get_radix_job_state(job_component_name: str, job_scheduler_port: int,
9393
response = await client.get(url=url)
9494
response.raise_for_status()
9595

96-
# LOGGER.debug("------")
97-
# response_dict = response.json()
98-
# LOGGER.debug(f"{response_dict=}")
99-
# LOGGER.debug("------")
96+
LOGGER.debug("------")
97+
response_dict = response.json()
98+
LOGGER.debug(f"{response_dict=}")
99+
LOGGER.debug("------")
100100

101+
# Have a suspicion that the may not alwqys contain an entry for status
102+
# This must be verified, but if that is the case, we must re-assess the RadixJobState pydantic model.
101103
radix_job_state = RadixJobState.model_validate_json(response.content)
102104
return radix_job_state
103105

0 commit comments

Comments
 (0)