Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date Filters Incorrectly Compile #5

Open
john-delivuk opened this issue May 22, 2023 · 1 comment
Open

Date Filters Incorrectly Compile #5

john-delivuk opened this issue May 22, 2023 · 1 comment

Comments

@john-delivuk
Copy link

john-delivuk commented May 22, 2023

Oracles implementation uses NUMTODSINTERVAL and NUMTOYMINTERVAL to create relative dates. These methods are not implemented in netsuite's version, go figure.

Additionally fixed dates render like so

(SuiteAnalytics.salesInvoiced.trandate >= '2023-05-01T00:00-04:00[America/New_York]' )

I've been hacking away on the driver for the last 3 days trying to fix #4 and I've come to realize I am not competent in clojure. I'm happy to provide feedback or testing if needed.

EDIT:
Just wanted to add that month and quarter work correctly.

Oracle Implementation

@ericcj
Copy link
Owner

ericcj commented Jun 1, 2023

hooray welcome fellow netsuite metabase user! please let me know if you need any help getting a pull request going/tested. it looks like we could just multiply by fractions of days like the weeks version does instead of using those unsupported functions https://timdietrich.me/blog/netsuite-suiteql-dates-times/ what's the problem with fixed dates exactly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants