From c7210bb29a9fbee0eb4f1ea554732e0d1612bb75 Mon Sep 17 00:00:00 2001 From: Erich Gubler Date: Mon, 29 Jul 2024 20:01:32 -0400 Subject: [PATCH] fix(process_reports)!: stop accepting lack of reports --- moz-webgpu-cts/src/process_reports.rs | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/moz-webgpu-cts/src/process_reports.rs b/moz-webgpu-cts/src/process_reports.rs index 7b4758d..12cc729 100644 --- a/moz-webgpu-cts/src/process_reports.rs +++ b/moz-webgpu-cts/src/process_reports.rs @@ -164,6 +164,14 @@ pub(crate) fn process_reports( meta_files_by_path, } = args; + if exec_report_paths.is_empty() { + log::error!(concat!( + "no report paths specified; ", + "this command doesn't make sense without them!" + )); + return Err(AlreadyReportedToCommandline); + } + let mut file_props_by_file = IndexMap::::default(); let mut entries_by_cts_path = IndexMap::>::default(); let mut other_entries_by_test = IndexMap::, TestEntry>::default(); @@ -252,8 +260,6 @@ pub(crate) fn process_reports( log::debug!("gathering reported test outcomes for reconciliation with metadata…"); - let using_reports = !exec_report_paths.is_empty(); - let (exec_reports_sender, exec_reports_receiver) = channel(); exec_report_paths .into_par_iter() @@ -439,7 +445,7 @@ pub(crate) fn process_reports( log::info!("new test entry: {test_entry_path:?}") } - if test_reported.is_empty() && using_reports { + if test_reported.is_empty() { let test_entry_path = &test_entry_path; let msg = lazy_format!("no entries found in reports for {:?}", test_entry_path); match preset { @@ -512,7 +518,7 @@ pub(crate) fn process_reports( reported: subtest_reported, } = subtest; - if subtest_reported.is_empty() && using_reports { + if subtest_reported.is_empty() { let test_entry_path = &test_entry_path; let subtest_name = &subtest_name; let msg = lazy_format!(