Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BootstrapBaseController can't handle multiple alerts #87

Open
roryprimrose opened this issue Mar 22, 2013 · 2 comments
Open

BootstrapBaseController can't handle multiple alerts #87

roryprimrose opened this issue Mar 22, 2013 · 2 comments

Comments

@roryprimrose
Copy link
Contributor

An exception is thrown if any of the functions in this controller are invoked more than once because the key already exists in the dictionary.

The other issue here is that because of this, the TempData support for alerts only supports single messages. An alternative would be to add a collection as the value of the TempData dictionary rather than just string. The _alerts partial view could then enumerate the collection to render multiple alerts.

@erichexter
Copy link
Owner

The initial impl is basic and i agree with your proposal.
On Mar 21, 2013 8:20 PM, "roryprimrose" notifications@github.com wrote:

An exception is thrown if any of the functions in this controller are
invoked more than once because the key already exists in the dictionary.

The other issue here is that because of this, the TempData support for
alerts only supports single messages. An alternative would be to add a
collection as the value of the TempData dictionary rather than just string.
The _alerts partial view could then enumerate the collection to render
multiple alerts.


Reply to this email directly or view it on GitHubhttps://github.com//issues/87
.

@serra
Copy link
Contributor

serra commented Mar 22, 2013

👍 Please also take #86 into account; and where possible keep the api backwards compatible for those who will do an occasional Update-Package twitter.bootstrap.mvc4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants