Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sp_Quickiestore: How about @sort_order = 'rows'? #498

Closed
ReeceGoding opened this issue Nov 6, 2024 · 1 comment
Closed

sp_Quickiestore: How about @sort_order = 'rows'? #498

ReeceGoding opened this issue Nov 6, 2024 · 1 comment

Comments

@ReeceGoding
Copy link
Contributor

ReeceGoding commented Nov 6, 2024

Is your feature request related to a problem? Please describe.
I've often heard it said that there is no good reason for your users to grab millions of rows from your server. Let's add a feature to sp_Quickiestore to find such cases: @sort_order = 'rows'.

Describe the solution you'd like
We already return avg_rowcount, total_rowcount, and max_rowcount, as well as some others in expert mode. They come from the same table as things that we've always sorted by, like cpu. Adding these on as an extra sort order should be super easy. I'd probably just make @sort_order = 'rows' sort by avg_rowcount.

Describe alternatives you've considered
Give more than one new @sort_order, e.g. 'total rows' and 'max rows'.

Are you ready to build the code for the feature?
I'm reluctant. I thought that I was free of adding new stuff to this...

IMPORTANT: If you're going to contribute code, please read the contributing guide first.
https://github.com/erikdarlingdata/DarlingData/blob/main/CONTRIBUTING.md
Sure.

@erikdarlingdata
Copy link
Owner

Closed via #501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants