Skip to content

Commit d0bed38

Browse files
committed
id: fix off-by-one.
1 parent 7bf2859 commit d0bed38

File tree

1 file changed

+3
-12
lines changed

1 file changed

+3
-12
lines changed

application.c

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -230,23 +230,14 @@ static app_action_t application_function_help(string_t *src, string_t *dst)
230230

231231
static app_action_t application_function_identification(string_t *src, string_t *dst)
232232
{
233-
int start, length;
234-
char last;
233+
int start;
235234
string_init(varname_identification, "identification");
236235

237236
if((start = string_sep(src, 0, 1, ' ')) > 0)
238237
{
239-
length = string_length(src) - 1;
240-
241-
if(length > 0)
242-
{
243-
last = string_at(src, length - 1);
244-
245-
if((last == '\n') || (last == '\r'))
246-
length--;
247-
}
238+
string_trim_nl(src);
248239

249-
if(!config_set_string(&varname_identification, -1, -1, src, start, length - start))
240+
if(!config_set_string(&varname_identification, -1, -1, src, start, string_length(src) - start))
250241
{
251242
string_append(dst, "> cannot set identification\n");
252243
return(app_action_error);

0 commit comments

Comments
 (0)