Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedback when importing elm project fails #11

Open
brandly opened this issue Oct 8, 2019 · 4 comments
Open

feedback when importing elm project fails #11

brandly opened this issue Oct 8, 2019 · 4 comments

Comments

@brandly
Copy link
Contributor

brandly commented Oct 8, 2019

i'm unable to import large elm project, at least without providing a github token. for example, importing the dependency graph for stil4m/elm-syntax causes a rate limit error before all the files have been fetched.

currently, the only way to know what happened is by looking in the dev tools. it'd be nice if we reported/displayed errors in this situation.

EDIT: just to confirm, providing a github token gets past the rate limit. the error message should point you towards getting a token of your own.

@erkal
Copy link
Owner

erkal commented Oct 9, 2019

thank you for reporting this.
we also need an explanation there, that the access token is needed for private repositories.
image
This does not tell so much

@erkal
Copy link
Owner

erkal commented Oct 14, 2019

I think putting there a question mark in a circle, which on mouseover shows the following text would be an ok solution:

providing an access token is necessary for the following cases:

  • accessing private repositories
  • preventing a rate limit error on big projects

So that we don't have to complicate the code for an edge case.
What do you think?

@erkal erkal removed the help wanted label Oct 14, 2019
@brandly
Copy link
Contributor Author

brandly commented Oct 14, 2019

it'd be good to display that text!

i think we still need to report errors in a few places, including this one. you may get rate limited, in which case we should encourage getting a github token, but maybe your wifi suddenly fails, in which case you just need to try again once you're online.

there's also no feedback if you try to import a DOT file and the file fails to parse. this has confused me a few times.

maybe we can have "toast" notifications popup, and use those notifications for a variety of errors.

@brandly
Copy link
Contributor Author

brandly commented Jan 15, 2020

i was using another app, and this popped up when i hit the GitHub rate limit.

Screen Shot 2020-01-14 at 10 56 46 PM

just wanted to record this for inspiration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants