Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFITSIO changed license: incompatible with GPL #402

Closed
olebole opened this issue Jun 13, 2024 · 14 comments
Closed

CFITSIO changed license: incompatible with GPL #402

olebole opened this issue Jun 13, 2024 · 14 comments

Comments

@olebole
Copy link
Contributor

olebole commented Jun 13, 2024

Starting with version 4.4.0. cfitsio changed its license to the "NASA Open Source Agreement" 1.3. While this license is OSI approved, Debian and GNU consider it as non-free. Aside from that it is not combinable with the GPL, which is the license of the Python fitsio package.

There already is addressed to HEASARC; however it may be useful that they know about the affected projects. Until this is resolved, I would recommend to stay with cfitsio 4.3.0.

(For the Debian package it does not matter, since we don't use the cfitsio provided with your package, but link to Debians cfitsio lib, which stays at 4.3.0 because of the licensing problems).

@esheldon
Copy link
Owner

I'm OK relicensing as long as the license is free.

@olebole
Copy link
Contributor Author

olebole commented Jun 13, 2024

I guess that is the problem here: From the GNU and Debian point of view, cfitsio isn't free anymore. I think that we cannot include cfitsio unless they revert the license change. If you would change to the NASA license, Debian also couldn't include your fitsio.

IMO the only way out here is to convince HEASARC to make a license change; everything else is desastrous for the astronomy community. cfitsio is one of the basic building blocks here.

@esheldon
Copy link
Owner

agreed

@esheldon
Copy link
Owner

We could bring this up on the cfitsio github page. I think we would need to be able to link to the debian email list or forum where this was discussed.

@esheldon
Copy link
Owner

Mr. Streicher do you know which part of the license makes it non free?

@olebole
Copy link
Contributor Author

olebole commented Jun 13, 2024

@lpsinger already contacted them to resolve. There is a comment on the GNU license page stating that the paragraph

G. Each Contributor represents that that its Modification is believed to be Contributor's original creation and does not violate any existing agreements, regulations, statutes or rules, and further that Contributor has sufficient rights to grant the rights conveyed by this Agreement.

makes it non-free because it does not allow f.e. to incorporate a software snippet from somewhere else (even when covered by a free license) into a NOSA licensed software.

That is also the Debian position as far as I know. However, I couldn't find an original discussion, only a discussion which questioned the decision (without a definitive outcome).

@beckermr
Copy link
Collaborator

Specifically, the only issue is the "Contributor's original creation" clause I think.

@lpsinger
Copy link

@trjaffe, is it true that you have decided to revert to the original license for the next release of cfitsio?

@trjaffe
Copy link

trjaffe commented Jun 13, 2024

Yes, we will be putting out a new release soon with the original license. Apologies for the confusion. @bryanirby

@bryanirby
Copy link

The CFITSIO main & master branches were updated for that new release (v4.4.1) last week. Also tagged with cfitsio4_4_1.

@olebole
Copy link
Contributor Author

olebole commented Jun 13, 2024

Specifically HEASARC/cfitsio@fed49d0
That looks great! Thank you very much!

@esheldon
Copy link
Owner

Yes, thank you

@esheldon
Copy link
Owner

See #404

@esheldon
Copy link
Owner

The new release 1.2.4 has cfitsio with updated license

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants