-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mdns]: Fixed some minor bugs #730
Conversation
Hi, @david-cermak Another topic: I noticed that mDNS creates a non-recursive mutex and this kind of mutex can only be taken once by one task refer to FreeRTOS: As far as I know, the APIs with the prefix |
Since it's used by public API as maximum length of user buffer Closes espressif#724
Closes coverity warning: 470092 Overflowed integer argument
Mixing esp_err_t (int) with err_t (uint8_t) from lwip. Closes coverity isssue: 470139 Overflowed return value
invalid mdns_if was handled for enabling/announcing pcbs, but not for the consequent browsing Closes coverity isssue: 470162 Out-of-bounds access
a69123d
to
24f55ce
Compare
Valid point, but won't address this in this PR. I'm going to work more on mdns in the near future though, so I'll reconsider. |
Thanks for the review @euripedesrocha and @zwx1995esp , I'll go ahead and merge this as is as I think I've addressed all the comments. I'll continue in #732 which depends on this one |
Github issues
Coverity issues