From 2646dcd23ab44e162b48e16c957e108ec1a67708 Mon Sep 17 00:00:00 2001 From: WanqQixiang Date: Fri, 3 Nov 2023 17:45:57 +0800 Subject: [PATCH 1/2] fix(mdns): fix compiling issue when disabling IPv4 --- .../query_advertise/main/mdns_example_main.c | 30 +++- .../examples/query_advertise/pytest_mdns.py | 144 +++++++++--------- .../query_advertise/sdkconfig.ci.eth_no_ipv4 | 15 ++ components/mdns/mdns.c | 76 ++++++--- components/mdns/mdns_console.c | 13 +- components/mdns/mdns_networking_lwip.c | 51 ++++--- components/mdns/mdns_networking_socket.c | 30 ++-- .../mdns/private_include/mdns_private.h | 10 +- .../components/esp_netif_linux/Kconfig | 6 + 9 files changed, 243 insertions(+), 132 deletions(-) create mode 100644 components/mdns/examples/query_advertise/sdkconfig.ci.eth_no_ipv4 diff --git a/components/mdns/examples/query_advertise/main/mdns_example_main.c b/components/mdns/examples/query_advertise/main/mdns_example_main.c index dec439bb4cb..a6aaea2d4c5 100644 --- a/components/mdns/examples/query_advertise/main/mdns_example_main.c +++ b/components/mdns/examples/query_advertise/main/mdns_example_main.c @@ -21,6 +21,12 @@ #include "driver/gpio.h" #include "netdb.h" +#if ESP_IDF_VERSION < ESP_IDF_VERSION_VAL(5, 1, 0) +/* CONFIG_LWIP_IPV4 was introduced in IDF v5.1, set CONFIG_LWIP_IPV4 to 1 by default for IDF v5.0 */ +#ifndef CONFIG_LWIP_IPV4 +#define CONFIG_LWIP_IPV4 1 +#endif // CONFIG_LWIP_IPV4 +#endif // ESP_IDF_VERSION < ESP_IDF_VERSION_VAL(5, 1, 0) #define EXAMPLE_MDNS_INSTANCE CONFIG_MDNS_INSTANCE #define EXAMPLE_BUTTON_GPIO CONFIG_MDNS_BUTTON_GPIO @@ -227,7 +233,7 @@ static void query_mdns_hosts_async(const char *host_name) vTaskDelay(50 / portTICK_PERIOD_MS); } } - +#ifdef CONFIG_LWIP_IPV4 static void query_mdns_host(const char *host_name) { ESP_LOGI(TAG, "Query A: %s.local", host_name); @@ -247,6 +253,7 @@ static void query_mdns_host(const char *host_name) ESP_LOGI(TAG, "Query A: %s.local resolved to: " IPSTR, host_name, IP2STR(&addr)); } +#endif // CONFIG_LWIP_IPV4 static void initialise_button(void) { @@ -265,7 +272,9 @@ static void check_button(void) bool new_level = gpio_get_level(EXAMPLE_BUTTON_GPIO); if (!new_level && old_level) { query_mdns_hosts_async("esp32-mdns"); +#ifdef CONFIG_LWIP_IPV4 query_mdns_host("esp32"); +#endif query_mdns_service("_arduino", "_tcp"); query_mdns_service("_http", "_tcp"); query_mdns_service("_printer", "_tcp"); @@ -286,7 +295,9 @@ static void mdns_example_task(void *pvParameters) { #if CONFIG_MDNS_RESOLVE_TEST_SERVICES == 1 /* Send initial queries that are started by CI tester */ +#ifdef CONFIG_LWIP_IPV4 query_mdns_host("tinytester"); +#endif query_mdns_host_with_gethostbyname("tinytester-lwip.local"); query_mdns_host_with_getaddrinfo("tinytester-lwip.local"); #endif @@ -362,7 +373,16 @@ static void query_mdns_host_with_gethostbyname(char *host) if (res) { unsigned int i = 0; while (res->h_addr_list[i] != NULL) { - ESP_LOGI(TAG, "gethostbyname: %s resolved to: %s", host, inet_ntoa(*(struct in_addr *) (res->h_addr_list[i]))); + ESP_LOGI(TAG, "gethostbyname: %s resolved to: %s", host, +#if defined(CONFIG_LWIP_IPV6) && defined(CONFIG_LWIP_IPV4) + res->h_addrtype == AF_INET ? inet_ntoa(*(struct in_addr *) (res->h_addr_list[i])) : + inet6_ntoa(*(struct in6_addr *) (res->h_addr_list[i])) +#elif defined(CONFIG_LWIP_IPV6) + inet6_ntoa(*(struct in6_addr *) (res->h_addr_list[i])) +#else + inet_ntoa(*(struct in_addr *) (res->h_addr_list[i])) +#endif + ); i++; } } @@ -384,10 +404,12 @@ static void query_mdns_host_with_getaddrinfo(char *host) if (!getaddrinfo(host, NULL, &hints, &res)) { while (res) { char *resolved_addr; -#if CONFIG_LWIP_IPV6 +#if defined(CONFIG_LWIP_IPV6) && defined(CONFIG_LWIP_IPV4) resolved_addr = res->ai_family == AF_INET ? inet_ntoa(((struct sockaddr_in *) res->ai_addr)->sin_addr) : - inet_ntoa(((struct sockaddr_in6 *) res->ai_addr)->sin6_addr); + inet6_ntoa(((struct sockaddr_in6 *) res->ai_addr)->sin6_addr); +#elif defined(CONFIG_LWIP_IPV6) + resolved_addr = inet6_ntoa(((struct sockaddr_in6 *) res->ai_addr)->sin6_addr); #else resolved_addr = inet_ntoa(((struct sockaddr_in *) res->ai_addr)->sin_addr); #endif // CONFIG_LWIP_IPV6 diff --git a/components/mdns/examples/query_advertise/pytest_mdns.py b/components/mdns/examples/query_advertise/pytest_mdns.py index 42364dfe31c..e78e094dd7a 100644 --- a/components/mdns/examples/query_advertise/pytest_mdns.py +++ b/components/mdns/examples/query_advertise/pytest_mdns.py @@ -87,26 +87,30 @@ def mdns_server(esp_host, events): continue data, addr = sock.recvfrom(1024) dns = dpkt.dns.DNS(data) - if len(dns.qd) > 0 and dns.qd[0].type == dpkt.dns.DNS_A: - if dns.qd[0].name == TESTER_NAME: - print('Received query: {} '.format(dns.__repr__())) - sock.sendto(get_dns_answer_to_mdns(TESTER_NAME), - (MCAST_GRP, UDP_PORT)) - elif dns.qd[0].name == TESTER_NAME_LWIP: - print('Received query: {} '.format(dns.__repr__())) - sock.sendto( - get_dns_answer_to_mdns_lwip(TESTER_NAME_LWIP, dns.id), - addr) - if len(dns.an) > 0 and dns.an[0].type == dpkt.dns.DNS_A: - print('Received answer from {}'.format(dns.an[0].name)) - if dns.an[0].name == esp_host + u'.local': - print('Received answer to esp32-mdns query: {}'.format( - dns.__repr__())) - events['esp_answered'].set() - if dns.an[0].name == esp_host + u'-delegated.local': - print('Received answer to esp32-mdns-delegate query: {}'. - format(dns.__repr__())) - events['esp_delegated_answered'].set() + if len(dns.qd) > 0: + for dns_query in dns.qd: + if dns_query.type == dpkt.dns.DNS_A: + if dns_query.name == TESTER_NAME: + print('Received query: {} '.format(dns.__repr__())) + sock.sendto(get_dns_answer_to_mdns(TESTER_NAME), + (MCAST_GRP, UDP_PORT)) + elif dns_query.name == TESTER_NAME_LWIP: + print('Received query: {} '.format(dns.__repr__())) + sock.sendto( + get_dns_answer_to_mdns_lwip(TESTER_NAME_LWIP, dns.id), + addr) + if len(dns.an) > 0: + for dns_answer in dns.an: + if dns_answer.type == dpkt.dns.DNS_A: + print('Received answer from {}'.format(dns_answer.name)) + if dns_answer.name == esp_host + u'.local': + print('Received answer to esp32-mdns query: {}'.format( + dns.__repr__())) + events['esp_answered'].set() + if dns_answer.name == esp_host + u'-delegated.local': + print('Received answer to esp32-mdns-delegate query: {}'.format( + dns.__repr__())) + events['esp_delegated_answered'].set() except socket.timeout: break except dpkt.UnpackError: @@ -133,62 +137,66 @@ def test_examples_protocol_mdns(dut): } mdns_responder = Thread(target=mdns_server, args=(str(specific_host), mdns_server_events)) - ipv4 = dut.expect(r'IPv4 address: (\d+\.\d+\.\d+\.\d+)[^\d]', - timeout=30)[1].decode() - ip_addresses = [ipv4] + ip_addresses = [] + if dut.app.sdkconfig.get('LWIP_IPV4') is True: + ipv4 = dut.expect(r'IPv4 address: (\d+\.\d+\.\d+\.\d+)[^\d]', + timeout=30)[1].decode() + ip_addresses.append(ipv4) if dut.app.sdkconfig.get('LWIP_IPV6') is True: ipv6_r = r':'.join((r'[0-9a-fA-F]{4}', ) * 8) ipv6 = dut.expect(ipv6_r, timeout=30)[0].decode() ip_addresses.append(ipv6) print('Connected with IP addresses: {}'.format(','.join(ip_addresses))) try: - # 3. check the mdns name is accessible. + # TODO: Add test for example disabling IPV4 mdns_responder.start() - if not mdns_server_events['esp_answered'].wait(timeout=30): - raise ValueError( - 'Test has failed: did not receive mdns answer within timeout') - if not mdns_server_events['esp_delegated_answered'].wait(timeout=30): - raise ValueError( - 'Test has failed: did not receive mdns answer for delegated host within timeout' + if dut.app.sdkconfig.get('LWIP_IPV4') is True: + # 3. check the mdns name is accessible. + if not mdns_server_events['esp_answered'].wait(timeout=30): + raise ValueError( + 'Test has failed: did not receive mdns answer within timeout') + if not mdns_server_events['esp_delegated_answered'].wait(timeout=30): + raise ValueError( + 'Test has failed: did not receive mdns answer for delegated host within timeout' + ) + # 4. check DUT output if mdns advertized host is resolved + dut.expect( + re.compile( + b'mdns-test: Query A: tinytester.local resolved to: 127.0.0.1') ) - # 4. check DUT output if mdns advertized host is resolved - dut.expect( - re.compile( - b'mdns-test: Query A: tinytester.local resolved to: 127.0.0.1') - ) - dut.expect( - re.compile( - b'mdns-test: gethostbyname: tinytester-lwip.local resolved to: 127.0.0.1' - )) - dut.expect( - re.compile( - b'mdns-test: getaddrinfo: tinytester-lwip.local resolved to: 127.0.0.1' - )) - # 5. check the DUT answers to `dig` command - dig_output = subprocess.check_output([ - 'dig', '+short', '-p', '5353', '@224.0.0.251', - '{}.local'.format(specific_host) - ]) - print('Resolving {} using "dig" succeeded with:\n{}'.format( - specific_host, dig_output)) - if not ipv4.encode('utf-8') in dig_output: - raise ValueError( - 'Test has failed: Incorrectly resolved DUT hostname using dig' - "Output should've contained DUT's IP address:{}".format(ipv4)) - # 6. check the DUT reverse lookup - if dut.app.sdkconfig.get('MDNS_RESPOND_REVERSE_QUERIES') is True: - for ip_address in ip_addresses: - dig_output = subprocess.check_output([ - 'dig', '+short', '-p', '5353', '@224.0.0.251', '-x', - '{}'.format(ip_address) - ]) - print('Reverse lookup for {} using "dig" succeeded with:\n{}'. - format(ip_address, dig_output)) - if specific_host not in dig_output.decode(): - raise ValueError( - 'Test has failed: Incorrectly resolved DUT IP address using dig' - "Output should've contained DUT's name:{}".format( - specific_host)) + dut.expect( + re.compile( + b'mdns-test: gethostbyname: tinytester-lwip.local resolved to: 127.0.0.1' + )) + dut.expect( + re.compile( + b'mdns-test: getaddrinfo: tinytester-lwip.local resolved to: 127.0.0.1' + )) + # 5. check the DUT answers to `dig` command + dig_output = subprocess.check_output([ + 'dig', '+short', '-p', '5353', '@224.0.0.251', + '{}.local'.format(specific_host) + ]) + print('Resolving {} using "dig" succeeded with:\n{}'.format( + specific_host, dig_output)) + if not ipv4.encode('utf-8') in dig_output: + raise ValueError( + 'Test has failed: Incorrectly resolved DUT hostname using dig' + "Output should've contained DUT's IP address:{}".format(ipv4)) + # 6. check the DUT reverse lookup + if dut.app.sdkconfig.get('MDNS_RESPOND_REVERSE_QUERIES') is True: + for ip_address in ip_addresses: + dig_output = subprocess.check_output([ + 'dig', '+short', '-p', '5353', '@224.0.0.251', '-x', + '{}'.format(ip_address) + ]) + print('Reverse lookup for {} using "dig" succeeded with:\n{}'. + format(ip_address, dig_output)) + if specific_host not in dig_output.decode(): + raise ValueError( + 'Test has failed: Incorrectly resolved DUT IP address using dig' + "Output should've contained DUT's name:{}".format( + specific_host)) finally: mdns_server_events['stop'].set() diff --git a/components/mdns/examples/query_advertise/sdkconfig.ci.eth_no_ipv4 b/components/mdns/examples/query_advertise/sdkconfig.ci.eth_no_ipv4 new file mode 100644 index 00000000000..b77a752705f --- /dev/null +++ b/components/mdns/examples/query_advertise/sdkconfig.ci.eth_no_ipv4 @@ -0,0 +1,15 @@ +CONFIG_IDF_TARGET="esp32" +CONFIG_MDNS_RESOLVE_TEST_SERVICES=y +CONFIG_MDNS_ADD_MAC_TO_HOSTNAME=y +CONFIG_MDNS_PUBLISH_DELEGATE_HOST=y +CONFIG_LWIP_DNS_SUPPORT_MDNS_QUERIES=y +CONFIG_LWIP_IPV4=n +CONFIG_EXAMPLE_CONNECT_ETHERNET=y +CONFIG_EXAMPLE_CONNECT_WIFI=n +CONFIG_EXAMPLE_USE_INTERNAL_ETHERNET=y +CONFIG_EXAMPLE_ETH_PHY_IP101=y +CONFIG_EXAMPLE_ETH_MDC_GPIO=23 +CONFIG_EXAMPLE_ETH_MDIO_GPIO=18 +CONFIG_EXAMPLE_ETH_PHY_RST_GPIO=5 +CONFIG_EXAMPLE_ETH_PHY_ADDR=1 +CONFIG_MDNS_BUTTON_GPIO=32 diff --git a/components/mdns/mdns.c b/components/mdns/mdns.c index 5e0c3523d5b..0cbaacab546 100644 --- a/components/mdns/mdns.c +++ b/components/mdns/mdns.c @@ -184,6 +184,11 @@ static inline void _mdns_clean_netif_ptr(mdns_if_t tcpip_if) static mdns_if_t _mdns_get_if_from_esp_netif(esp_netif_t *esp_netif) { for (int i = 0; i < MDNS_MAX_INTERFACES; ++i) { + // The predefined netifs in the static array are NULL when firstly calling this function + // if IPv4 is disabled. Set these netifs here. + if (s_esp_netifs[i].netif == NULL && s_esp_netifs[i].predefined) { + s_esp_netifs[i].netif = esp_netif_from_preset_if(s_esp_netifs[i].predef_if); + } if (esp_netif == s_esp_netifs[i].netif) { return i; } @@ -1059,6 +1064,7 @@ static uint16_t _mdns_append_srv_record(uint8_t *packet, uint16_t *index, mdns_s return record_length; } +#ifdef CONFIG_LWIP_IPV4 /** * @brief appends A record to a packet, incrementing the index * @@ -1108,8 +1114,9 @@ static uint16_t _mdns_append_a_record(uint8_t *packet, uint16_t *index, const ch record_length += 4; return record_length; } +#endif /* CONFIG_LWIP_IPV4 */ -#if CONFIG_LWIP_IPV6 +#ifdef CONFIG_LWIP_IPV6 /** * @brief appends AAAA record to a packet, incrementing the index * @@ -1232,7 +1239,7 @@ static bool _mdns_if_is_dup(mdns_if_t tcpip_if) return false; } -#if CONFIG_LWIP_IPV6 +#ifdef CONFIG_LWIP_IPV6 /** * @brief Check if IPv6 address is NULL */ @@ -1247,7 +1254,7 @@ static bool _ipv6_address_is_zero(esp_ip6_addr_t ip6) } return true; } -#endif +#endif /* CONFIG_LWIP_IPV6 */ static uint8_t _mdns_append_host_answer(uint8_t *packet, uint16_t *index, mdns_host_item_t *host, uint8_t address_type, bool flush, bool bye) @@ -1257,17 +1264,19 @@ static uint8_t _mdns_append_host_answer(uint8_t *packet, uint16_t *index, mdns_h while (addr != NULL) { if (addr->addr.type == address_type) { +#ifdef CONFIG_LWIP_IPV4 if (address_type == ESP_IPADDR_TYPE_V4 && _mdns_append_a_record(packet, index, host->hostname, addr->addr.u_addr.ip4.addr, flush, bye) <= 0) { break; } -#if CONFIG_LWIP_IPV6 +#endif /* CONFIG_LWIP_IPV4 */ +#ifdef CONFIG_LWIP_IPV6 if (address_type == ESP_IPADDR_TYPE_V6 && _mdns_append_aaaa_record(packet, index, host->hostname, (uint8_t *)addr->addr.u_addr.ip6.addr, flush, bye) <= 0) { break; } -#endif // CONFIG_LWIP_IPV6 +#endif /* CONFIG_LWIP_IPV6 */ num_records++; } addr = addr->next; @@ -1360,7 +1369,9 @@ static uint8_t _mdns_append_answer(uint8_t *packet, uint16_t *index, mdns_out_an return _mdns_append_txt_record(packet, index, answer->service, answer->flush, answer->bye) > 0; } else if (answer->type == MDNS_TYPE_SDPTR) { return _mdns_append_sdptr_record(packet, index, answer->service, answer->flush, answer->bye) > 0; - } else if (answer->type == MDNS_TYPE_A) { + } +#ifdef CONFIG_LWIP_IPV4 + else if (answer->type == MDNS_TYPE_A) { if (answer->host == &_mdns_self_host) { esp_netif_ip_info_t if_ip_info; if (!mdns_is_netif_ready(tcpip_if, MDNS_IP_PROTOCOL_V4) && _mdns_server->interfaces[tcpip_if].pcbs[MDNS_IP_PROTOCOL_V4].state != PCB_DUP) { @@ -1387,7 +1398,8 @@ static uint8_t _mdns_append_answer(uint8_t *packet, uint16_t *index, mdns_out_an return _mdns_append_host_answer(packet, index, answer->host, ESP_IPADDR_TYPE_V4, answer->flush, answer->bye); } } -#if CONFIG_LWIP_IPV6 +#endif /* CONFIG_LWIP_IPV4 */ +#ifdef CONFIG_LWIP_IPV6 else if (answer->type == MDNS_TYPE_AAAA) { if (answer->host == &_mdns_self_host) { struct esp_ip6_addr if_ip6s[NETIF_IPV6_MAX_NUMS]; @@ -1425,7 +1437,7 @@ static uint8_t _mdns_append_answer(uint8_t *packet, uint16_t *index, mdns_out_an answer->bye); } } -#endif +#endif /* CONFIG_LWIP_IPV6 */ return 0; } @@ -1713,12 +1725,14 @@ static mdns_tx_packet_t *_mdns_alloc_packet_default(mdns_if_t tcpip_if, mdns_ip_ packet->tcpip_if = tcpip_if; packet->ip_protocol = ip_protocol; packet->port = MDNS_SERVICE_PORT; +#ifdef CONFIG_LWIP_IPV4 if (ip_protocol == MDNS_IP_PROTOCOL_V4) { esp_ip_addr_t addr = ESP_IP4ADDR_INIT(224, 0, 0, 251); memcpy(&packet->dst, &addr, sizeof(esp_ip_addr_t)); } -#if CONFIG_LWIP_IPV6 - else { +#endif +#ifdef CONFIG_LWIP_IPV6 + if (ip_protocol == MDNS_IP_PROTOCOL_V6) { esp_ip_addr_t addr = ESP_IP6ADDR_INIT(0x000002ff, 0, 0, 0xfb000000); memcpy(&packet->dst, &addr, sizeof(esp_ip_addr_t)); } @@ -2877,6 +2891,7 @@ static void _mdns_dup_interface(mdns_if_t tcpip_if) } } +#ifdef CONFIG_LWIP_IPV4 /** * @brief Detect IPv4 address collision */ @@ -2890,7 +2905,6 @@ static int _mdns_check_a_collision(esp_ip4_addr_t *ip, mdns_if_t tcpip_if) if (esp_netif_get_ip_info(_mdns_get_esp_netif(tcpip_if), &if_ip_info)) { return 1;//they win } - int ret = memcmp((uint8_t *)&if_ip_info.ip.addr, (uint8_t *)&ip->addr, sizeof(esp_ip4_addr_t)); if (ret > 0) { return -1;//we win @@ -2911,8 +2925,9 @@ static int _mdns_check_a_collision(esp_ip4_addr_t *ip, mdns_if_t tcpip_if) } return 0;//same } +#endif /* CONFIG_LWIP_IPV4 */ -#if CONFIG_LWIP_IPV6 +#ifdef CONFIG_LWIP_IPV6 /** * @brief Detect IPv6 address collision */ @@ -2946,7 +2961,7 @@ static int _mdns_check_aaaa_collision(esp_ip6_addr_t *ip, mdns_if_t tcpip_if) } return 0;//same } -#endif +#endif /* CONFIG_LWIP_IPV6 */ static bool _hostname_is_ours(const char *hostname) { @@ -3509,22 +3524,25 @@ void mdns_parse_packet(mdns_rx_packet_t *packet) #ifndef CONFIG_MDNS_SKIP_SUPPRESSING_OWN_QUERIES // Check if the packet wasn't sent by us +#ifdef CONFIG_LWIP_IPV4 if (packet->ip_protocol == MDNS_IP_PROTOCOL_V4) { esp_netif_ip_info_t if_ip_info; if (esp_netif_get_ip_info(_mdns_get_esp_netif(packet->tcpip_if), &if_ip_info) == ESP_OK && memcmp(&if_ip_info.ip.addr, &packet->src.u_addr.ip4.addr, sizeof(esp_ip4_addr_t)) == 0) { return; } -#if CONFIG_LWIP_IPV6 - } else { + } +#endif /* CONFIG_LWIP_IPV4 */ +#ifdef CONFIG_LWIP_IPV6 + if (packet->ip_protocol == MDNS_IP_PROTOCOL_V6) { struct esp_ip6_addr if_ip6; if (esp_netif_get_ip6_linklocal(_mdns_get_esp_netif(packet->tcpip_if), &if_ip6) == ESP_OK && memcmp(&if_ip6, &packet->src.u_addr.ip6, sizeof(esp_ip6_addr_t)) == 0) { return; } -#endif } -#endif +#endif /* CONFIG_LWIP_IPV6 */ +#endif // CONFIG_MDNS_SKIP_SUPPRESSING_OWN_QUERIES // Check for the minimum size of mdns packet if (len <= MDNS_HEAD_ADDITIONAL_OFFSET) { @@ -3887,7 +3905,7 @@ void mdns_parse_packet(mdns_rx_packet_t *packet) } } -#if CONFIG_LWIP_IPV6 +#ifdef CONFIG_LWIP_IPV6 else if (type == MDNS_TYPE_AAAA) {//ipv6 esp_ip_addr_t ip6; ip6.type = ESP_IPADDR_TYPE_V6; @@ -3940,7 +3958,8 @@ void mdns_parse_packet(mdns_rx_packet_t *packet) } } -#endif +#endif /* CONFIG_LWIP_IPV6 */ +#ifdef CONFIG_LWIP_IPV4 else if (type == MDNS_TYPE_A) { esp_ip_addr_t ip; ip.type = ESP_IPADDR_TYPE_V4; @@ -3993,6 +4012,7 @@ void mdns_parse_packet(mdns_rx_packet_t *packet) } } +#endif /* CONFIG_LWIP_IPV4 */ } //end while if (parsed_packet->authoritative) { @@ -4094,6 +4114,7 @@ static void perform_event_action(mdns_if_t mdns_if, mdns_event_actions_t action) } #ifdef CONFIG_MDNS_RESPOND_REVERSE_QUERIES +#ifdef CONFIG_LWIP_IPV4 if (action & MDNS_EVENT_IP4_REVERSE_LOOKUP) { esp_netif_ip_info_t if_ip_info; if (esp_netif_get_ip_info(_mdns_get_esp_netif(mdns_if), &if_ip_info) == ESP_OK) { @@ -4107,7 +4128,7 @@ static void perform_event_action(mdns_if_t mdns_if, mdns_event_actions_t action) } } } - +#endif /* CONFIG_LWIP_IPV4 */ #ifdef CONFIG_LWIP_IPV6 if (action & MDNS_EVENT_IP6_REVERSE_LOOKUP) { esp_ip6_addr_t addr6; @@ -5483,22 +5504,25 @@ esp_err_t mdns_init(void) #endif uint8_t i; -#if CONFIG_LWIP_IPV6 +#ifdef CONFIG_LWIP_IPV6 esp_ip6_addr_t tmp_addr6; #endif +#ifdef CONFIG_LWIP_IPV4 esp_netif_ip_info_t if_ip_info; +#endif for (i = 0; i < MDNS_MAX_INTERFACES; i++) { -#if CONFIG_LWIP_IPV6 +#ifdef CONFIG_LWIP_IPV6 if (!esp_netif_get_ip6_linklocal(_mdns_get_esp_netif(i), &tmp_addr6) && !_ipv6_address_is_zero(tmp_addr6)) { _mdns_enable_pcb(i, MDNS_IP_PROTOCOL_V6); } #endif +#ifdef CONFIG_LWIP_IPV4 if (!esp_netif_get_ip_info(_mdns_get_esp_netif(i), &if_ip_info) && if_ip_info.ip.addr) { _mdns_enable_pcb(i, MDNS_IP_PROTOCOL_V4); } +#endif } - if (_mdns_service_task_start()) { //service start failed! err = ESP_FAIL; @@ -6468,6 +6492,7 @@ esp_err_t mdns_lookup_selfhosted_service(const char *instance, const char *servi return ESP_OK; } +#ifdef CONFIG_LWIP_IPV4 esp_err_t mdns_query_a(const char *name, uint32_t timeout, esp_ip4_addr_t *addr) { mdns_result_t *result = NULL; @@ -6504,8 +6529,9 @@ esp_err_t mdns_query_a(const char *name, uint32_t timeout, esp_ip4_addr_t *addr) mdns_query_results_free(result); return ESP_ERR_NOT_FOUND; } +#endif /* CONFIG_LWIP_IPV4 */ -#if CONFIG_LWIP_IPV6 +#ifdef CONFIG_LWIP_IPV6 esp_err_t mdns_query_aaaa(const char *name, uint32_t timeout, esp_ip6_addr_t *addr) { mdns_result_t *result = NULL; @@ -6542,7 +6568,7 @@ esp_err_t mdns_query_aaaa(const char *name, uint32_t timeout, esp_ip6_addr_t *ad mdns_query_results_free(result); return ESP_ERR_NOT_FOUND; } -#endif +#endif /* CONFIG_LWIP_IPV6 */ #ifdef MDNS_ENABLE_DEBUG diff --git a/components/mdns/mdns_console.c b/components/mdns/mdns_console.c index 992ce9a8fff..075be0682dd 100644 --- a/components/mdns/mdns_console.c +++ b/components/mdns/mdns_console.c @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: 2015-2022 Espressif Systems (Shanghai) CO LTD + * SPDX-FileCopyrightText: 2015-2023 Espressif Systems (Shanghai) CO LTD * * SPDX-License-Identifier: Apache-2.0 */ @@ -8,6 +8,7 @@ #include "esp_console.h" #include "argtable3/argtable3.h" #include "mdns.h" +#include "mdns_private.h" static const char *ip_protocol_str[] = {"V4", "V6", "MAX"}; @@ -50,6 +51,7 @@ static struct { struct arg_end *end; } mdns_query_a_args; +#ifdef CONFIG_LWIP_IPV4 static int cmd_mdns_query_a(int argc, char **argv) { int nerrors = arg_parse(argc, argv, (void **) &mdns_query_a_args); @@ -106,8 +108,9 @@ static void register_mdns_query_a(void) ESP_ERROR_CHECK( esp_console_cmd_register(&cmd_init) ); } +#endif /* CONFIG_LWIP_IPV4 */ -#if CONFIG_LWIP_IPV6 +#ifdef CONFIG_LWIP_IPV6 static int cmd_mdns_query_aaaa(int argc, char **argv) { int nerrors = arg_parse(argc, argv, (void **) &mdns_query_a_args); @@ -164,7 +167,7 @@ static void register_mdns_query_aaaa(void) ESP_ERROR_CHECK( esp_console_cmd_register(&cmd_init) ); } -#endif +#endif /* CONFIG_LWIP_IPV6 */ static struct { struct arg_str *instance; @@ -1042,8 +1045,10 @@ void mdns_console_register(void) register_mdns_service_txt_remove(); register_mdns_service_remove_all(); +#ifdef CONFIG_LWIP_IPV4 register_mdns_query_a(); -#if CONFIG_LWIP_IPV6 +#endif +#ifdef CONFIG_LWIP_IPV6 register_mdns_query_aaaa(); #endif register_mdns_query_txt(); diff --git a/components/mdns/mdns_networking_lwip.c b/components/mdns/mdns_networking_lwip.c index 402f1205394..635f7e352e9 100644 --- a/components/mdns/mdns_networking_lwip.c +++ b/components/mdns/mdns_networking_lwip.c @@ -96,6 +96,7 @@ static esp_err_t _udp_join_group(mdns_if_t if_inx, mdns_ip_protocol_t ip_protoco netif = esp_netif_get_netif_impl(tcpip_if); assert(netif); +#if LWIP_IPV4 if (ip_protocol == MDNS_IP_PROTOCOL_V4) { ip4_addr_t multicast_addr; IP4_ADDR(&multicast_addr, 224, 0, 0, 251); @@ -110,21 +111,22 @@ static esp_err_t _udp_join_group(mdns_if_t if_inx, mdns_ip_protocol_t ip_protoco } } } -#if CONFIG_LWIP_IPV6 - else { +#endif // LWIP_IPV4 +#if LWIP_IPV6 + if (ip_protocol == MDNS_IP_PROTOCOL_V6) { ip_addr_t multicast_addr = IPADDR6_INIT(0x000002ff, 0, 0, 0xfb000000); if (join) { - if (mld6_joingroup_netif(netif, &(multicast_addr.u_addr.ip6))) { + if (mld6_joingroup_netif(netif, ip_2_ip6(&multicast_addr))) { return ESP_ERR_INVALID_STATE; } } else { - if (mld6_leavegroup_netif(netif, &(multicast_addr.u_addr.ip6))) { + if (mld6_leavegroup_netif(netif, ip_2_ip6(&multicast_addr))) { return ESP_ERR_INVALID_STATE; } } } -#endif +#endif // LWIP_IPV6 return ESP_OK; } @@ -152,29 +154,34 @@ static void _udp_recv(void *arg, struct udp_pcb *upcb, struct pbuf *pb, const ip packet->tcpip_if = MDNS_MAX_INTERFACES; packet->pb = this_pb; packet->src_port = rport; -#if CONFIG_LWIP_IPV6 +#if LWIP_IPV4 && LWIP_IPV6 packet->src.type = raddr->type; memcpy(&packet->src.u_addr, &raddr->u_addr, sizeof(raddr->u_addr)); -#else +#elif LWIP_IPV4 packet->src.type = IPADDR_TYPE_V4; - memcpy(&packet->src.u_addr.ip4, &raddr->addr, sizeof(ip_addr_t)); + packet->src.u_addr.ip4.addr = raddr->addr; +#elif LWIP_IPV6 + packet->src.type = IPADDR_TYPE_V6; + memcpy(&packet->src.u_addr.ip6, raddr, sizeof(ip_addr_t)); #endif packet->dest.type = packet->src.type; +#if LWIP_IPV4 if (packet->src.type == IPADDR_TYPE_V4) { packet->ip_protocol = MDNS_IP_PROTOCOL_V4; struct ip_hdr *iphdr = (struct ip_hdr *)(((uint8_t *)(packet->pb->payload)) - UDP_HLEN - IP_HLEN); packet->dest.u_addr.ip4.addr = iphdr->dest.addr; packet->multicast = ip4_addr_ismulticast(&(packet->dest.u_addr.ip4)); } -#if CONFIG_LWIP_IPV6 - else { +#endif // LWIP_IPV4 +#if LWIP_IPV6 + if (packet->src.type == IPADDR_TYPE_V6) { packet->ip_protocol = MDNS_IP_PROTOCOL_V6; struct ip6_hdr *ip6hdr = (struct ip6_hdr *)(((uint8_t *)(packet->pb->payload)) - UDP_HLEN - IP6_HLEN); memcpy(&packet->dest.u_addr.ip6.addr, (uint8_t *)ip6hdr->dest.addr, 16); packet->multicast = ip6_addr_ismulticast(&(packet->dest.u_addr.ip6)); } -#endif +#endif // LWIP_IPV6 //lwip does not return the proper pcb if you have more than one for the same multicast address (but different interfaces) struct netif *netif = NULL; @@ -182,15 +189,14 @@ static void _udp_recv(void *arg, struct udp_pcb *upcb, struct pbuf *pb, const ip for (i = 0; i < MDNS_MAX_INTERFACES; i++) { netif = esp_netif_get_netif_impl(_mdns_get_esp_netif(i)); if (s_interfaces[i].proto && netif && netif == ip_current_input_netif ()) { +#if LWIP_IPV4 if (packet->src.type == IPADDR_TYPE_V4) { -#if CONFIG_LWIP_IPV6 - if ((packet->src.u_addr.ip4.addr & netif->netmask.u_addr.ip4.addr) != (netif->ip_addr.u_addr.ip4.addr & netif->netmask.u_addr.ip4.addr)) { -#else - if ((packet->src.u_addr.ip4.addr & netif->netmask.addr) != (netif->ip_addr.addr & netif->netmask.addr)) { -#endif //packet source is not in the same subnet + if ((packet->src.u_addr.ip4.addr & ip_2_ip4(&netif->netmask)->addr) != (ip_2_ip4(&netif->ip_addr)->addr & ip_2_ip4(&netif->netmask)->addr)) { + //packet source is not in the same subnet break; } } +#endif // LWIP_IPV4 packet->tcpip_if = i; found = true; break; @@ -347,12 +353,17 @@ size_t _mdns_udp_pcb_write(mdns_if_t tcpip_if, mdns_ip_protocol_t ip_protocol, c memcpy((uint8_t *)pbt->payload, data, len); ip_addr_t ip_add_copy; -#if CONFIG_LWIP_IPV6 +#if LWIP_IPV6 && LWIP_IPV4 ip_add_copy.type = ip->type; memcpy(&(ip_add_copy.u_addr), &(ip->u_addr), sizeof(ip_add_copy.u_addr)); -#else - memcpy(&(ip_add_copy.addr), &(ip->u_addr), sizeof(ip_add_copy.addr)); -#endif // CONFIG_LWIP_IPV6 +#elif LWIP_IPV4 + ip_add_copy.addr = ip->u_addr.ip4.addr; +#elif LWIP_IPV6 +#if LWIP_IPV6_SCOPES + ip_add_copy.zone = ip->u_addr.ip6.zone; +#endif // LWIP_IPV6_SCOPES + memcpy(ip_add_copy.addr, ip->u_addr.ip6.addr, sizeof(ip_add_copy.addr)); +#endif mdns_api_call_t msg = { .tcpip_if = tcpip_if, diff --git a/components/mdns/mdns_networking_socket.c b/components/mdns/mdns_networking_socket.c index 0440299f1cb..8411e26e6d7 100644 --- a/components/mdns/mdns_networking_socket.c +++ b/components/mdns/mdns_networking_socket.c @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: 2021-2022 Espressif Systems (Shanghai) CO LTD + * SPDX-FileCopyrightText: 2021-2023 Espressif Systems (Shanghai) CO LTD * * SPDX-License-Identifier: Apache-2.0 */ @@ -138,11 +138,13 @@ static inline char *get_string_address(struct sockaddr_storage *source_addr) static char address_str[40]; // 40=(8*4+7+term) is the max size of ascii IPv6 addr "XXXX:XX...XX:XXXX" char *res = NULL; // Convert ip address to string +#ifdef CONFIG_LWIP_IPV4 if (source_addr->ss_family == PF_INET) { res = inet_ntoa_r(((struct sockaddr_in *)source_addr)->sin_addr, address_str, sizeof(address_str)); } +#endif #ifdef CONFIG_LWIP_IPV6 - else if (source_addr->ss_family == PF_INET6) { + if (source_addr->ss_family == PF_INET6) { res = inet6_ntoa_r(((struct sockaddr_in6 *)source_addr)->sin6_addr, address_str, sizeof(address_str)); } #endif @@ -157,6 +159,7 @@ static inline size_t espaddr_to_inet(const esp_ip_addr_t *addr, const uint16_t p { size_t ss_addr_len = 0; memset(in_addr, 0, sizeof(struct sockaddr_storage)); +#ifdef CONFIG_LWIP_IPV4 if (ip_protocol == MDNS_IP_PROTOCOL_V4 && addr->type == ESP_IPADDR_TYPE_V4) { in_addr->ss_family = PF_INET; #if !defined(CONFIG_IDF_TARGET_LINUX) @@ -167,8 +170,9 @@ static inline size_t espaddr_to_inet(const esp_ip_addr_t *addr, const uint16_t p in_addr_ip4->sin_port = port; in_addr_ip4->sin_addr.s_addr = addr->u_addr.ip4.addr; } -#if CONFIG_LWIP_IPV6 - else if (ip_protocol == MDNS_IP_PROTOCOL_V6 && addr->type == ESP_IPADDR_TYPE_V6) { +#endif // CONFIG_LWIP_IPV4 +#ifdef CONFIG_LWIP_IPV6 + if (ip_protocol == MDNS_IP_PROTOCOL_V6 && addr->type == ESP_IPADDR_TYPE_V6) { memset(in_addr, 0, sizeof(struct sockaddr_storage)); in_addr->ss_family = PF_INET6; #if !defined(CONFIG_IDF_TARGET_LINUX) @@ -212,6 +216,7 @@ size_t _mdns_udp_pcb_write(mdns_if_t tcpip_if, mdns_ip_protocol_t ip_protocol, c static inline void inet_to_espaddr(const struct sockaddr_storage *in_addr, esp_ip_addr_t *addr, uint16_t *port) { +#ifdef CONFIG_LWIP_IPV4 if (in_addr->ss_family == PF_INET) { struct sockaddr_in *in_addr_ip4 = (struct sockaddr_in *)in_addr; memset(addr, 0, sizeof(esp_ip_addr_t)); @@ -219,8 +224,9 @@ static inline void inet_to_espaddr(const struct sockaddr_storage *in_addr, esp_i addr->u_addr.ip4.addr = in_addr_ip4->sin_addr.s_addr; addr->type = ESP_IPADDR_TYPE_V4; } -#if CONFIG_LWIP_IPV6 - else if (in_addr->ss_family == PF_INET6) { +#endif /* CONFIG_LWIP_IPV4 */ +#ifdef CONFIG_LWIP_IPV6 + if (in_addr->ss_family == PF_INET6) { struct sockaddr_in6 *in_addr_ip6 = (struct sockaddr_in6 *)in_addr; memset(addr, 0, sizeof(esp_ip_addr_t)); *port = in_addr_ip6->sin6_port; @@ -383,7 +389,7 @@ esp_err_t _mdns_pcb_init(mdns_if_t tcpip_if, mdns_ip_protocol_t ip_protocol) static int create_socket(esp_netif_t *netif) { -#if CONFIG_LWIP_IPV6 +#ifdef CONFIG_LWIP_IPV6 int sock = socket(PF_INET6, SOCK_DGRAM, 0); #else int sock = socket(PF_INET, SOCK_DGRAM, 0); @@ -398,7 +404,7 @@ static int create_socket(esp_netif_t *netif) ESP_LOGE(TAG, "Failed setsockopt() to set SO_REUSEADDR. errno=%d: %s\n", errno, strerror(errno)); } // Bind the socket to any address -#if CONFIG_LWIP_IPV6 +#ifdef CONFIG_LWIP_IPV6 struct sockaddr_in6 saddr = { INADDR_ANY }; saddr.sin6_family = AF_INET6; saddr.sin6_port = htons(5353); @@ -434,7 +440,7 @@ static int create_socket(esp_netif_t *netif) return -1; } -#if CONFIG_LWIP_IPV6 +#ifdef CONFIG_LWIP_IPV6 static int socket_add_ipv6_multicast_group(int sock, esp_netif_t *netif) { int ifindex = esp_netif_get_netif_impl_index(netif); @@ -457,6 +463,7 @@ static int socket_add_ipv6_multicast_group(int sock, esp_netif_t *netif) } #endif // CONFIG_LWIP_IPV6 +#ifdef CONFIG_LWIP_IPV4 static int socket_add_ipv4_multicast_group(int sock, esp_netif_t *netif) { struct ip_mreq imreq = { 0 }; @@ -481,13 +488,16 @@ static int socket_add_ipv4_multicast_group(int sock, esp_netif_t *netif) err: return err; } +#endif // CONFIG_LWIP_IPV4 static int join_mdns_multicast_group(int sock, esp_netif_t *netif, mdns_ip_protocol_t ip_protocol) { +#ifdef CONFIG_LWIP_IPV4 if (ip_protocol == MDNS_IP_PROTOCOL_V4) { return socket_add_ipv4_multicast_group(sock, netif); } -#if CONFIG_LWIP_IPV6 +#endif // CONFIG_LWIP_IPV4 +#ifdef CONFIG_LWIP_IPV6 if (ip_protocol == MDNS_IP_PROTOCOL_V6) { return socket_add_ipv6_multicast_group(sock, netif); } diff --git a/components/mdns/private_include/mdns_private.h b/components/mdns/private_include/mdns_private.h index 627d42c3e1d..56d76b28ea0 100644 --- a/components/mdns/private_include/mdns_private.h +++ b/components/mdns/private_include/mdns_private.h @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: 2015-2022 Espressif Systems (Shanghai) CO LTD + * SPDX-FileCopyrightText: 2015-2023 Espressif Systems (Shanghai) CO LTD * * SPDX-License-Identifier: Apache-2.0 */ @@ -39,6 +39,14 @@ #define NETIF_IPV6_MAX_NUMS 3 #endif +#if ESP_IDF_VERSION < ESP_IDF_VERSION_VAL(5, 1, 0) +/* CONFIG_LWIP_IPV4 was introduced in IDF v5.1 */ +/* For IDF v5.0, set CONFIG_LWIP_IPV4 to 1 by default */ +#ifndef CONFIG_LWIP_IPV4 +#define CONFIG_LWIP_IPV4 1 +#endif // CONFIG_LWIP_IPV4 +#endif // ESP_IDF_VERSION < ESP_IDF_VERSION_VAL(5, 1, 0) + /** Number of configured interfaces */ #if MDNS_MAX_PREDEF_INTERFACES > CONFIG_MDNS_MAX_INTERFACES #warning Number of configured interfaces is less then number of predefined interfaces. Please update CONFIG_MDNS_MAX_INTERFACES. diff --git a/components/mdns/tests/host_test/components/esp_netif_linux/Kconfig b/components/mdns/tests/host_test/components/esp_netif_linux/Kconfig index f91ec201bd9..3b3c309920b 100644 --- a/components/mdns/tests/host_test/components/esp_netif_linux/Kconfig +++ b/components/mdns/tests/host_test/components/esp_netif_linux/Kconfig @@ -6,4 +6,10 @@ menu "LWIP-MOCK-CONFIG" help Enable/disable IPv6 + config LWIP_IPV4 + bool "Enable IPv4" + default y + help + Enable/disable IPv4 + endmenu From 5000a9a20a647c588824f3e56ab125d29a58b64e Mon Sep 17 00:00:00 2001 From: WanqQixiang Date: Wed, 10 Jan 2024 17:21:43 +0800 Subject: [PATCH 2/2] fix(mdns): fix the logic of creating pcb for networking socket --- components/mdns/mdns_networking_socket.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/components/mdns/mdns_networking_socket.c b/components/mdns/mdns_networking_socket.c index 8411e26e6d7..a99a9cc2d9f 100644 --- a/components/mdns/mdns_networking_socket.c +++ b/components/mdns/mdns_networking_socket.c @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: 2021-2023 Espressif Systems (Shanghai) CO LTD + * SPDX-FileCopyrightText: 2021-2024 Espressif Systems (Shanghai) CO LTD * * SPDX-License-Identifier: Apache-2.0 */ @@ -352,17 +352,9 @@ static bool create_pcb(mdns_if_t tcpip_if, mdns_ip_protocol_t ip_protocol) } int sock = s_interfaces[tcpip_if].sock; esp_netif_t *netif = _mdns_get_esp_netif(tcpip_if); - if (sock >= 0) { - mdns_ip_protocol_t other_ip_proto = ip_protocol == MDNS_IP_PROTOCOL_V4 ? MDNS_IP_PROTOCOL_V6 : MDNS_IP_PROTOCOL_V4; - int err = join_mdns_multicast_group(sock, netif, other_ip_proto); - if (err < 0) { - ESP_LOGE(TAG, "Failed to add ipv6 multicast group for protocol %d", ip_protocol); - return false; - } - s_interfaces[tcpip_if].proto |= (other_ip_proto == MDNS_IP_PROTOCOL_V4 ? PROTO_IPV4 : PROTO_IPV6); - return true; + if (sock < 0) { + sock = create_socket(netif); } - sock = create_socket(netif); if (sock < 0) { ESP_LOGE(TAG, "Failed to create the socket!"); return false;