From 82cccbd92fae14fa0b589e7e76b2ef7a0bd04553 Mon Sep 17 00:00:00 2001 From: Binghuan Zhang <574953550@qq.com> Date: Sun, 10 Nov 2019 19:27:27 -0500 Subject: [PATCH] update contrib md --- CONTRIBUTING.md | 5 ++++- README.md | 4 +++- src/api/client.ts | 4 ++-- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 357b07f..dfc8a4b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -28,7 +28,7 @@ To develop douban.fm-electron on your machine, here are some tips: 2. Install douban.fm-electron dependencies ```bash - npm install --dev + npm install ``` ## Unit testing @@ -43,3 +43,6 @@ Use eslint and prettier. Use `electron-builder`: - for Mac, issue `npx electron-builder -m` +- for Windows, issue `npx electron-builder -w --x64` + +Then find the installer under `./dist` diff --git a/README.md b/README.md index 162ff3c..d6f3566 100644 --- a/README.md +++ b/README.md @@ -3,6 +3,8 @@ A tiny, elegant douban.fm desktop client developed with electron. ![此处配图 from doc]() +If anything doesn't work, try refreshing! + ## Features - login/logout, cookie saving - channels: @@ -10,7 +12,7 @@ A tiny, elegant douban.fm desktop client developed with electron. - douban recommended / 豆瓣推荐 - liked songs / 红心歌曲 - personal channel / 私人频道 -- set window on top +- set window on top / 置顶 ## Shortcuts - pause or play: `space` diff --git a/src/api/client.ts b/src/api/client.ts index 5c87498..3b352dd 100644 --- a/src/api/client.ts +++ b/src/api/client.ts @@ -166,11 +166,11 @@ class ApiClient { } public async downloadSong() { - return; + throw Error('not implemented'); } public async downloadPlaylist() { - return; + throw Error('not implemented'); } }