Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIPIP Meeting 107 #346

Closed
10 tasks done
poojaranjan opened this issue Jul 4, 2024 · 3 comments
Closed
10 tasks done

EIPIP Meeting 107 #346

poojaranjan opened this issue Jul 4, 2024 · 3 comments

Comments

@poojaranjan
Copy link
Member

poojaranjan commented Jul 4, 2024

Date and Time

July 17, 2024 at 14:00 UTC

Location

Zoom: TBA in the Discord #eip-editing channel

YouTube Recording: EIPIP Meetings

Agenda

1. Discuss Open Issues/PRs, and other topics

Edit to Final Proposals

Update to EIP-1

TBA

Misc Issue/ requires attention?

to Draft

Call for Input

Call For Input Status Inclination/Result Deadline
343 Open July 28, 2024
345 Open Aug 02, 2024
348 Open Aug 17, 2024

2. Other discussions and updates from past meetings

  • Working Group update
  • Security Considerations and Security Disclosures in EIPs ref: Comment

3. EIPs Insight - Monthly EIPs status reporting.

Repo Issues PRs Total
EIP 7 62 69
ERC 6 73 79
RIP 2 12 14

4. EIP Editing Office Hour

  • Agenda 41 Video 40

5. Review action items from earlier meetings

Next Meeting date & time - Aug 21, 2024 (3rd Wed of the Month) at 14:00 UTC

@poojaranjan poojaranjan mentioned this issue Jul 4, 2024
18 tasks
@Dexaran
Copy link

Dexaran commented Jul 15, 2024

@poojaranjan I would like to reiterate on Security Considerations and security disclosures in EIPs.

During the previous call 105 I was raising this general problem and highlighted the state of ERC-20 problem as well. I was asked to provide links to previous discussions and proposals, so here is my comment that stores this information #340 (comment)

So, my points:

  1. Informational EIP describing ERC-20 problems. EIP editors told me to create one. I created it. EIP editors rejected it. The problem with ERC-20 standard persists. More money is lost. I would like to revive that EIP and I think that it is quite important to document known issues for implementors.
  2. "Final = no change" rule resulted in a situation where an issue which is known for 7 years keeps causing financial damage to Ethereum community. It is reasonable to apply this rule to specification section of the EIP, but not to "security considerations" because new issues can be discovered after EIP is finalized.
  3. My proposal: implement a new rule for EIP process: "If something caused financial damage and it is transparently verifiable through blockchain history - add it to the security considerations section".

@poojaranjan
Copy link
Member Author

Summary

1. Discuss Open Issues/PRs, and other topics

ethereum/ERCs#403

  • Too many changes to a Final EIP. Should not be encouraged.
  • All editors on the call decided to close the PR.

ethereum/ERCs#342

  • One of the author found it okay at high level but needs to be verified.
  • @lightclient added a comment to get the program to validate the code. He'll verify and get back to the group.

ethereum/ERCs#524

  • a bunch of changes to multiple EIPs
  • @SamWilsn made a comment and closed

ethereum/EIPs#8590

  • most editors already agreed to this was waiting on @lightclient 's approval
  • confirmed & merged!

ethereum/EIPs#8673

  • Incorrect repo
  • PR closed

ethereum/ERCs#540

  • merged

ethereum/EIPs#8734

  • spam, closed

ethereum/EIPs#8724

  • Issue with auto merge, force merged.

Call for Input

#343

  • 3 editors are in favor, no one opposed. Deadline is July 28

#345

  • 3 editors agreed to Delete the EIP from the EIP GitHub repo.

#348

  • most of the editors are in favor, but, couldn't get any author's approval.
  • The proposal is to merge this with 3 editors approval even in absence of the authors.
  • @poojaranjan proposed to make it a rule that editors may force merge such PRs but, @SamWilsn wants to take it case by case basis.

2. Other discussions and updates from past meetings

Working Group update

  • Encourage and onboard Reviewers to support each GitHub repo
  • Reviewers may leave comments to help EIP Editors
  • Non-editorial PR approval tag can be created to support EIP Editors.

Security Considerations and Security Disclosures in EIPs ref: #346 (comment)

  • @Dexaran provided summary and proposals
  • Detailed comment added here and here
  • A Call For Input opened to collect input for decision making
  • to allow modifications to Final proposals when all of the following are met:
    • The modification is only appending new content to the Security Considerations section;
    • The modification describes a consideration that has caused financial loss.
      EIP Editors have the final say but the input here will help editors to make decision.

3. EIPs Insight - Monthly EIPs status reporting.

Next Meeting on Aug 21, 2024 at 14:00 UTC

  • Editors agree to have once a month meeting thus, the group decided to have the meeting on every 3rd Wednesday of the month.

@poojaranjan poojaranjan mentioned this issue Jul 20, 2024
3 tasks
@poojaranjan
Copy link
Member Author

Closing in favor of #350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants