Skip to content

Transaction order in block #171

Closed Answered by ajsutton
grantweii asked this question in Core Protocol
Jan 2, 2024 · 2 comments · 3 replies
Discussion options

You must be logged in to vote

Yeah I think you may be right about that except that it's min(GasTipCap, GasFeeCap - BaseFee). The code is attempting to handle the legacy transaction case where the miner is paid the GasPrice - BaseFee but it winds up applying the same logic to 1559 transactions and may prioritise a transaction that has a high MaxFeeCap but low MaxTipCap which is sub-optimal. That code comes straight for upstream geth I believe and potentially reduces the value of blocks geth produces on L1 so probably should be fixed there.

Replies: 2 comments 3 replies

Comment options

You must be logged in to vote
3 replies
@grantweii
Comment options

@ajsutton
Comment options

Answer selected by grantweii
@grantweii
Comment options

Comment options

You must be logged in to vote
0 replies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-protocol Questions relating to the core protocol and how the OP Stack works. discussion-metrics Used by Github Action to gather discussion metrics on the question and answer section.
2 participants