You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
We have try the newest main branch (0fb0dcbefc50882f1bb02fafcb27f47b463875c9) to test whether it can support the chain which is generated by op-contracts/v2.0.0-beta.2
Our chain is using:
custom gas token
op-plasma with KeccakCommitment
isFraudProof is false
Describe the solution you'd like
can let the deploy-config in op-contracts/v2.0.0-beta.2 work well
Describe alternatives you've considered
For now we can only modify local code, but can not pass the ci. And a related issue is:
Additional context
In our test, the issue at least contains:
in getting-started/.deploy address json file, we should add FaultDisputeGamePermissionedDisputeGame in manual, which should contain in the rollup.json when execute the script in op-contracts/v2.0.0-beta.2, so it's a bug in this value
also in this json file, we need to delete AnchorStateRegistry and AnchorStateRegistryProxy which is a bed condition in this repo to judge whether it uses FraudProof
op side advice us to config Eip1559Elasticity to 10, but in check-genesis step, it requires us to set 6:
for custome gas token, when this contract is version op-contracts/v2.0.0-beta.2. :
Is your feature request related to a problem? Please describe.
We have try the newest main branch (
0fb0dcbefc50882f1bb02fafcb27f47b463875c9
) to test whether it can support the chain which is generated byop-contracts/v2.0.0-beta.2
Our chain is using:
KeccakCommitment
false
Describe the solution you'd like
can let the deploy-config in
op-contracts/v2.0.0-beta.2
work wellDescribe alternatives you've considered
For now we can only modify local code, but can not pass the ci. And a related issue is:
ethereum-optimism/optimism#11185 (comment)
Additional context
In our test, the issue at least contains:
getting-started/.deploy
address json file, we should addFaultDisputeGame
PermissionedDisputeGame
in manual, which should contain in the rollup.json when execute the script inop-contracts/v2.0.0-beta.2
, so it's a bug in this valueAnchorStateRegistry
andAnchorStateRegistryProxy
which is a bed condition in this repo to judge whether it usesFraudProof
Eip1559Elasticity
to10
, but incheck-genesis
step, it requires us to set 6:op-contracts/v2.0.0-beta.2
. :superchain-registry/add-chain/main.go
Lines 206 to 212 in c971994
L206
err
will benil
, but in L208, theerr.Error()
will panic due tonull pointer
, related to issue When use
GenericCommitment
in alt-da, some logic is useless or incorrect in op-node optimism#11185 (comment), meanwhile, it's better if the legency field can use old value, rather then must set them to default/0 valueThe text was updated successfully, but these errors were encountered: