Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move l1 rpc url from superchain init to validation #609

Open
bitwiseguy opened this issue Sep 23, 2024 · 0 comments
Open

Move l1 rpc url from superchain init to validation #609

bitwiseguy opened this issue Sep 23, 2024 · 0 comments

Comments

@bitwiseguy
Copy link
Collaborator

Currently the superchain module checks for existence of env vars to determine if CI is running. If CI is running the l1 rpc url used for tests is changed.

This is test/ci logic and therefore it belongs in the test module (validation) instead of the superchain module that gets imported by downstream software

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant