From faec593132b00341856f8d83b3d7fca00a8500c5 Mon Sep 17 00:00:00 2001 From: refcell Date: Mon, 29 Jul 2024 11:27:12 -0400 Subject: [PATCH] fix(opt8n): handle errors --- bin/opt8n/src/opt8n.rs | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/bin/opt8n/src/opt8n.rs b/bin/opt8n/src/opt8n.rs index ec4fefc..25e024d 100644 --- a/bin/opt8n/src/opt8n.rs +++ b/bin/opt8n/src/opt8n.rs @@ -44,10 +44,11 @@ impl Opt8n { output_file: PathBuf, genesis: Option, ) -> Result { - let genesis = genesis.as_ref().map(|path| { - serde_json::from_reader(File::open(path).expect("TODO: handle error Invalid path")) - .expect("TODO: handle error Invalid genesis") - }); + let genesis = if let Some(genesis) = genesis.as_ref() { + serde_json::from_reader(File::open(genesis)?)? + } else { + None + }; let node_config = node_config .unwrap_or_default() @@ -106,7 +107,7 @@ impl Opt8n { // Mine the block and generate the execution fixture opt8n.mine_block().await; - let block = new_blocks.next().await.expect("TODO: handle error"); + let block = new_blocks.next().await.ok_or(eyre!("No new block"))?; if let Some(block) = opt8n.eth_api.backend.get_block_by_hash(block.hash) { opt8n.generate_execution_fixture(block).await?; } @@ -147,7 +148,7 @@ impl Opt8n { .eth_api .txpool_content() .await - .expect("TODO: handle error") + .expect("Failed to get txpool content") .pending .len(); @@ -207,7 +208,7 @@ impl Opt8n { self.node_handle.http_provider(), BlockId::from(block.header.number - 1), ) - .expect("Could not create AlloyDB"), + .ok_or_else(|| eyre!("Failed to create AlloyDB"))?, ); let block_env = BlockEnv {