Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute CREATE address without RLP library #783

Closed
chfast opened this issue Jan 8, 2024 · 4 comments · Fixed by #1055
Closed

Compute CREATE address without RLP library #783

chfast opened this issue Jan 8, 2024 · 4 comments · Fixed by #1055
Assignees
@chfast
Labels
good first issue Good for newcomers

Comments

@chfast
Copy link
Member

chfast commented Jan 8, 2024

We want to decouple RLP library (mostly used in testing infrastructure and MPT hashing) from the core EVM state modifications. The CREATE address derivation is the only place where RLP is used. For this we only need to implement RLP encoding for uint64.

See the TODO comment at https://github.com/ethereum/evmone/blob/v0.11.0/test/state/host.cpp#L149.
@chfast chfast added the good first issue Good for newcomers label Jan 8, 2024
@AbhinavMir AbhinavMir mentioned this issue Feb 11, 2024
Closed
@AbhinavMir
Copy link

AbhinavMir commented Feb 11, 2024 •
edited
Loading

Hi @chfast ! Does the draft PR above look right? I looked at how Aleth used to encode JSON objects and bounced off from there to create a rlp_encode_uint64 function.

@elijahhampton
Copy link
Contributor

Looks like the PR for this wasn't accepted and has gone stale. I can pick this up @chfast

@chfast
Copy link
Member Author

chfast commented Sep 27, 2024

Ok, give it a try. For the clarification: any JSON should not be involved.

@chfast chfast mentioned this issue Oct 16, 2024
Merged
chfast added a commit that referenced this issue Oct 17, 2024
@chfast
state: Implement CREATE address without RLP lib
61be3bb 
Remove Host's dependency on RLP library by re-implementing
`compute_create_address()`.

Closes #783.
chfast added a commit that referenced this issue Oct 17, 2024
@chfast
state: Implement CREATE address without RLP lib
92375c0 
Remove Host's dependency on RLP library by re-implementing
`compute_create_address()`.

Closes #783.
@chfast chfast mentioned this issue Oct 17, 2024
Merged
@chfast chfast assigned chfast and unassigned elijahhampton Oct 17, 2024
@chfast
Copy link
Member Author

chfast commented Oct 17, 2024

I made a draft for it: #1055.

chfast added a commit that referenced this issue Oct 18, 2024
@chfast
state: Implement CREATE address without RLP lib
a9468d4 
Remove Host's dependency on RLP library by re-implementing
`compute_create_address()`.

Closes #783.
chfast added a commit that referenced this issue Oct 18, 2024
@chfast
state: Implement CREATE address without RLP lib
7080764 
Remove Host's dependency on RLP library by re-implementing
`compute_create_address()`.

Closes #783.
chfast added a commit that referenced this issue Oct 18, 2024
@chfast
state: Implement CREATE address without RLP lib
78af74a 
Remove Host's dependency on RLP library by re-implementing
`compute_create_address()`.

Closes #783.
chfast added a commit that referenced this issue Oct 18, 2024
@chfast
state: Implement CREATE address without RLP lib
07eb905 
Remove Host's dependency on RLP library by re-implementing
`compute_create_address()`.

Closes #783.
chfast added a commit that referenced this issue Oct 18, 2024
@chfast
state: Implement CREATE address without RLP lib
68eba83 
Remove Host's dependency on RLP library by re-implementing
`compute_create_address()`.

Closes #783.
@chfast chfast closed this as completed in d2b9dc2 Oct 23, 2024
chfast added a commit that referenced this issue Oct 23, 2024
@chfast
state: Implement CREATE address without RLP lib (#1055)
c8787ec 
Remove Host's dependency on RLP library by re-implementing
`compute_create_address()`.

Closes #783.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chfast chfast

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
3 participants
@chfast @elijahhampton @AbhinavMir