Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Code Examples from Using Web3.js to Ethers.js #15759

Open
codersjj opened this issue Jan 23, 2025 · 1 comment · May be fixed by #15760
Open

Update Code Examples from Using Web3.js to Ethers.js #15759

codersjj opened this issue Jan 23, 2025 · 1 comment · May be fixed by #15760
Labels
documentation 📖 low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. must have eventually Something we consider essential but not enough to prevent us from releasing Solidity 1.0 without it.

Comments

@codersjj
Copy link

codersjj commented Jan 23, 2025 •
edited
Loading

Page

Introduction to Smart Contracts - A Simple Smart Contract - Subcurrency Example

Abstract

Web3.js libraries are being sunset on March 4th, 2025, as announced by the Web3.js team. Considering this, I propose updating the current Solidity documentation code examples to use Ethers.js instead of Web3.js.

Pull request

#15760
@codersjj codersjj linked a pull request Jan 23, 2025 that will close this issue
Open
@cameel cameel added low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. must have eventually Something we consider essential but not enough to prevent us from releasing Solidity 1.0 without it. labels Jan 23, 2025
@cameel
Copy link
Member

cameel commented Jan 23, 2025

Sure, why not. If it's being deprecated, we should not be showing it in the intro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation 📖 low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. must have eventually Something we consider essential but not enough to prevent us from releasing Solidity 1.0 without it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch from web3.js to ethers.js in the Introduction to Smart Contracts codersjj/solidity
2 participants
@cameel @codersjj