Skip to content
This repository has been archived by the owner on Apr 10, 2020. It is now read-only.

Support circle areas #22

Open
brockfanning opened this issue Nov 29, 2016 · 8 comments
Open

Support circle areas #22

brockfanning opened this issue Nov 29, 2016 · 8 comments

Comments

@brockfanning
Copy link
Contributor

This library already supports rect and poly areas, but doesn't support the last type: circle. Adding this support is not trivial, but not impossible. I could go ahead and give it a shot. However if any big changes are in the works, I might wait until things settle. @etienne-martin do you think it's appropriate to work on this feature now?

@etienne-martin
Copy link
Owner

You're good to go, I just merged some recent changes.

We're not working on new features right now.

Thanks for your help.

@andreys42
Copy link

Does library support circles area now?

@brockfanning
Copy link
Contributor Author

@andrey290494 I put up my attempt at this as a pull request. I'm not sure if there have been any developments in the meantime.

@andreys42
Copy link

@etienne-martin , @brockfanning, any ideas on how to implement such ability to library? Circles area supporting will make this lib much usefull

@brockfanning
Copy link
Contributor Author

@andrey290494 My PR for this is still up: #23

@andreys42
Copy link

andreys42 commented Jun 20, 2019

@brockfanning it's strange. I'm updated mapify.js using your PR changes. Now circle areas appears, but popover appears not in a circle. Looks like popover coords calculated wrong

@brockfanning
Copy link
Contributor Author

@andrey290494 Ah, OK, yes I don't recall testing with popovers. I don't have much bandwidth to continue with this, so hopefully you have time to experiment with a solution.

@andreys42
Copy link

@brockfanning, OK, will try

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants