-
Notifications
You must be signed in to change notification settings - Fork 30
Support circle areas #22
Comments
You're good to go, I just merged some recent changes. We're not working on new features right now. Thanks for your help. |
Does library support circles area now? |
@andrey290494 I put up my attempt at this as a pull request. I'm not sure if there have been any developments in the meantime. |
@etienne-martin , @brockfanning, any ideas on how to implement such ability to library? Circles area supporting will make this lib much usefull |
@andrey290494 My PR for this is still up: #23 |
@brockfanning it's strange. I'm updated mapify.js using your PR changes. Now circle areas appears, but popover appears not in a circle. Looks like popover coords calculated wrong |
@andrey290494 Ah, OK, yes I don't recall testing with popovers. I don't have much bandwidth to continue with this, so hopefully you have time to experiment with a solution. |
@brockfanning, OK, will try |
This library already supports rect and poly areas, but doesn't support the last type: circle. Adding this support is not trivial, but not impossible. I could go ahead and give it a shot. However if any big changes are in the works, I might wait until things settle. @etienne-martin do you think it's appropriate to work on this feature now?
The text was updated successfully, but these errors were encountered: