From a73451e51b1e5ef0a69f4570a2df46ea2262b234 Mon Sep 17 00:00:00 2001
From: etorreborre <etorreborre@yahoo.com>
Date: Sat, 5 Aug 2023 17:08:13 +0200
Subject: [PATCH] refactor: remove deprecations

---
 build.sbt                                          |  2 +-
 .../main/scala/org/specs2/data/HopcroftKarp.scala  |  7 ++++---
 .../scala/org/specs2/runner/Specs2TestEngine.scala |  4 ++--
 .../scala/org/specs2/matcher/JsonMatchers.scala    | 14 +++++++-------
 4 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/build.sbt b/build.sbt
index c3410c6faa..080ca7baf4 100644
--- a/build.sbt
+++ b/build.sbt
@@ -278,7 +278,7 @@ lazy val compilationOptions = Seq(
   "-language:implicitConversions,postfixOps",
   "-Ykind-projector",
   "-Xcheck-macros",
-  "-deprecation:false",
+  "-deprecation:true",
   "-unchecked",
   "-feature"
 )
diff --git a/common/shared/src/main/scala/org/specs2/data/HopcroftKarp.scala b/common/shared/src/main/scala/org/specs2/data/HopcroftKarp.scala
index 4412de2552..8f69094f6f 100644
--- a/common/shared/src/main/scala/org/specs2/data/HopcroftKarp.scala
+++ b/common/shared/src/main/scala/org/specs2/data/HopcroftKarp.scala
@@ -2,7 +2,8 @@ package org.specs2
 package data
 
 import scala.collection.mutable
-import scala.util.control.NonLocalReturns.*
+import scala.util.boundary
+import scala.util.boundary.*
 
 /** Hopcroft-Karp (https://en.wikipedia.org/wiki/Hopcroft%E2%80%93Karp_algorithm) algorithm for finding the maximum
   * matching in a bipartite graph
@@ -38,13 +39,13 @@ object HopcroftKarp:
           }
       dist(nil) != Int.MaxValue
 
-    def dfs(v: Int): Boolean = returning {
+    def dfs(v: Int): Boolean = boundary {
       if v != -1 then
         edges.get(v).toSeq.flatten.foreach { u =>
           if dist(pair2(u)) == dist(v) + 1 && dfs(pair2(u)) then
             pair2.put(u, v)
             pair1.put(v, u)
-            throwReturn(true)
+            break(true)
         }
         dist.put(v, Int.MaxValue)
         false
diff --git a/junit/src/main/scala/org/specs2/runner/Specs2TestEngine.scala b/junit/src/main/scala/org/specs2/runner/Specs2TestEngine.scala
index ee402295e5..3350289e74 100644
--- a/junit/src/main/scala/org/specs2/runner/Specs2TestEngine.scala
+++ b/junit/src/main/scala/org/specs2/runner/Specs2TestEngine.scala
@@ -1,6 +1,6 @@
 package org.specs2.runner
 
-import collection.convert.ImplicitConversions.*
+import scala.jdk.CollectionConverters.*
 
 import org.junit.platform.engine.*
 import org.junit.platform.engine.discovery.*
@@ -65,7 +65,7 @@ class Specs2TestEngine extends TestEngine:
     listener.executionStarted(descriptor)
     descriptor match
       case Specs2EngineContainerDescriptor(_, _) =>
-        descriptor.getChildren.foreach(d => executeTest(d, listener))
+        descriptor.getChildren.asScala.foreach(d => executeTest(d, listener))
         listener.executionFinished(descriptor, TestExecutionResult.successful)
       case Specs2EngineTestDescriptor(_, _, execution) =>
         execution.startExecution(env).executionResult.runAction(env.executionEnv) match
diff --git a/matcher-extra/shared/src/main/scala/org/specs2/matcher/JsonMatchers.scala b/matcher-extra/shared/src/main/scala/org/specs2/matcher/JsonMatchers.scala
index e03e4a4571..f9d7572261 100644
--- a/matcher-extra/shared/src/main/scala/org/specs2/matcher/JsonMatchers.scala
+++ b/matcher-extra/shared/src/main/scala/org/specs2/matcher/JsonMatchers.scala
@@ -366,8 +366,8 @@ trait JsonSelectors:
 
     def select(value: Any): Option[Any] =
       value.asInstanceOf[Matchable] match
-        case l: List[_]   => this.select(l)
-        case m: Map[_, _] => this.select(m)
+        case l: List[?]   => this.select(l)
+        case m: Map[?, ?] => this.select(m)
         case _            => None
 
     def name: String =
@@ -431,8 +431,8 @@ trait JsonSelectors:
 
     def select(value: Any): Option[Any] =
       value.asInstanceOf[Matchable] match
-        case m: Map[_, _] => this.select(m)
-        case kv: (_, _)   => this.select(kv)
+        case m: Map[?, ?] => this.select(m)
+        case kv: (?, ?)   => this.select(kv)
         case _            => None
 
     def name: String =
@@ -453,9 +453,9 @@ trait JsonSelectors:
 
     def select(value: Any): Option[Any] =
       value.asInstanceOf[Matchable] match
-        case l: List[_]   => this.select(l)
-        case m: Map[_, _] => this.select(m)
-        case kv: (_, _)   => this.select(kv.asInstanceOf[(String, Any)])
+        case l: List[?]   => this.select(l)
+        case m: Map[?, ?] => this.select(m)
+        case kv: (?, ?)   => this.select(kv.asInstanceOf[(String, Any)])
         case _            => None
 
     def name: String =