Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkTrustAnchorSignature unimplemented and unused #18

Open
J08nY opened this issue Jun 28, 2021 · 1 comment
Open

checkTrustAnchorSignature unimplemented and unused #18

J08nY opened this issue Jun 28, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@J08nY
Copy link

J08nY commented Jun 28, 2021

The checkTrustAnchorSignature method in GatewayDataDownloadBtpServiceImpl is unimplemented but returns true. Furthermore the method is unused.

private boolean checkTrustAnchorSignature(TrustListItemDto trustListItemDto) {
// Implement me...
return true;
}

It is possible that this functionality does not need to verify the trust anchor signatures to work securely or that it is done elsewhere but this is still a big code smell and should be handled. (Returning true from a signature verification method that is not implemented is just dangerous!)

@J08nY J08nY added the bug Something isn't working label Jun 28, 2021
@jurosens
Copy link
Contributor

It is a bug and will be fixed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants