Vertaisarviointi2 #2
Description
The git repository is well organized and code is following pep8.
Like how you have separated services and repositories as taught on Ohte.
The database consist of 5 tables which is the minimum requirement for the course work, good job!
The code is easy to follow thanks to well named methods and parameters.
Testing the heroku production:
(+) I was able to create user and admin accounts
(-) there is no link to creating user/admin in the navigation bar
(+) password check works good!
(-) only check maybe to add was that i allows username==password
(+) I was able to login with both accounts
(+) I was able to create a new book as admin
(-) after creating a book it doesn't redirect to allow give review, instead to add more books
(+) I was able to make new reviews as admin and user
(-) i wish i could see the whole book list somewhere, or at least new books added
Overral the site works nicely now as it is and I hope you take the minuses as impovement suggestions.
Good job!