Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KafkaFlow may lose an error if retry strategy fails #131

Open
rtar opened this issue Dec 22, 2020 · 0 comments
Open

KafkaFlow may lose an error if retry strategy fails #131

rtar opened this issue Dec 22, 2020 · 0 comments

Comments

@rtar
Copy link
Contributor

rtar commented Dec 22, 2020

KafkaFlow may lose an error if retry strategy fails at the following line:
https://github.com/evolution-gaming/kafka-flow/blob/master/core/src/main/scala/com/evolutiongaming/kafka/flow/KafkaFlow.scala#L81

The problem is that as the join is never called the, if fiber dies with an error, the Resource will never be cancelled and the application will just happily hang.
rtar added a commit that referenced this issue Dec 28, 2020
@rtar
Partial fix for #131: allow joining the underlying fiber.
3d9909e
rtar added a commit that referenced this issue Dec 28, 2020
@rtar
Improved API for #131
25e8ce2
rtar added a commit that referenced this issue Dec 28, 2020
@rtar
GH #131: Do not cache version twice
41369fc
rtar added a commit that referenced this issue Dec 31, 2020
@rtar
GH #131: Try using timeout to debug hanging.
d0ddf08
rtar added a commit that referenced this issue Jan 6, 2021
@rtar
GH #131: Make sure it is not Cassandra hanging up.
df1b197
rtar added a commit that referenced this issue Jan 6, 2021
@rtar
GH #131: Fixed documentation compilation.
ce37f93
rtar added a commit that referenced this issue Jan 7, 2021
@rtar
FromGFuture was incorrectly inferred from Async (#131)
1d23da1
rtar added a commit that referenced this issue Jan 7, 2021
@rtar
Fix compilation issue in 2.12.x (#131)
44d9ce2
rtar added a commit that referenced this issue Jan 8, 2021
@rtar
Improve coverage of suspicious code (#131).
d28a24b
rtar added a commit that referenced this issue Jan 8, 2021
@rtar
Removed unused imports (#131)
6780d7a
rtar added a commit that referenced this issue Jan 8, 2021
@rtar
Test for failures in integration tests instead (#131)
9afd78f
rtar added a commit that referenced this issue Jan 8, 2021
@rtar
Check that flow returns on hangup (#131).
06411bd
rtar added a commit that referenced this issue Jan 8, 2021
@rtar
Actual forgotten spec (#131).
95d92ae
rtar added a commit that referenced this issue Jan 8, 2021
@rtar
Show more information on exception (#131).
5bef560
rtar added a commit that referenced this issue Jan 8, 2021
@rtar
Fixed logging bug (#131).
1c6aa75
rtar added a commit that referenced this issue Jan 8, 2021
@rtar
Do not try to flush anything on cancel (#131).
37a8a6e
rtar added a commit that referenced this issue Jan 10, 2021
@rtar
Removed all debugging code because the bug is fixed now (#131).
cddb626
rtar added a commit that referenced this issue Jan 10, 2021
@rtar
Remove useless imports (#131).
fbcc4d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rtar